Bug 435031 - Breeze Light Colour Scheme does not respect Colour Scheme KCM values
Summary: Breeze Light Colour Scheme does not respect Colour Scheme KCM values
Status: RESOLVED DUPLICATE of bug 433059
Alias: None
Product: Breeze
Classification: Plasma
Component: general (show other bugs)
Version: 5.21.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-27 18:35 UTC by Paul McAuley
Modified: 2021-04-01 18:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Breze Light with inactive window on left and active window on right -- both have the same titlebar text colour, despite settings (386.22 KB, image/png)
2021-04-01 02:54 UTC, Paul McAuley
Details
kdeglobals file corresponding to screenshot (4.41 KB, text/plain)
2021-04-01 02:55 UTC, Paul McAuley
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul McAuley 2021-03-27 18:35:53 UTC
I noticed that the Breeze Light colour scheme has poor contrast between active and inactive windows.

Upon investigating, the colour scheme KCM has the following (seemingly reasonable) values:
Active Titlebar text: #232629
Inactive Titlebar text: #707d8a

However, when I look at the actual titlebar text with a dropper tool both active and inactive are set to #232629 !


SOFTWARE/OS VERSIONS
Operating System: openSUSE Leap 15.2
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Nate Graham 2021-03-31 16:13:30 UTC
Does the problem get fixed if you reset your color scheme to something else, and then go back to Breeze Light? If so, the color migration probably didn't work properly for you. :/
Comment 2 Paul McAuley 2021-03-31 19:45:21 UTC
(In reply to Nate Graham from comment #1)
> Does the problem get fixed if you reset your color scheme to something else,
> and then go back to Breeze Light? If so, the color migration probably didn't
> work properly for you. :/

No it doesn't. I've been using numerous distributions recently, and on every distribution that I've used I've only ever seen a deep black background titlebar colour. The grey #707d8a never appears, even though I see it set in the colour scheme.
Comment 3 Nate Graham 2021-03-31 20:11:17 UTC
Can you please attach a screenshot that shows an active and an inactive window? Also can you please attach your ~/.config/kdeglobals file (after scrubbing out anything you deem too personal to share)? Thanks!
Comment 4 Paul McAuley 2021-04-01 02:54:16 UTC
Created attachment 137217 [details]
Breze Light with inactive window on left and active window on right -- both have the same titlebar text colour, despite settings
Comment 5 Paul McAuley 2021-04-01 02:55:47 UTC
Created attachment 137218 [details]
kdeglobals file corresponding to screenshot
Comment 6 Nate Graham 2021-04-01 15:39:22 UTC
Thanks, that's helpful!

Your screenshot shows the intentional un-edited Breeze Light appearance: the active titlebar's color is #dee0e2, while the inactive titlebar's color is #eff0f1.

I think I see the confusion though. You are editing the titlebar colors while using a color scheme that has header colors. In Plasma 5.21, when a color scheme has Header colors in it, its Titlebar active/inactive colors are ignored, and the Header colors are used to create a unified look for the window's entire header area.

If you don't like this, you have three options:

1. Switch to a color scheme that does not have Header colors (e.g. the old Breeze color scheme, which is still shipped)
2. Remove the Header colors from your current color scheme
3. Create the desired appearance using the Header colors of your current color scheme, by adjusting the Normal/Inactive background colors in the Header section

If you wish to use #2, I'm afraid the procedure is rather annoying since we were not able to write a GUI to remove header colors in time for 5.21. Sorry about that. To do this manually, you will need to save a copy of the color scheme, open it at ~/.local/share/color-schemes/[the color scheme] and remove the "Header" sections, then switch to another color scheme in the Colors KCM and back to your now-header-less custom color scheme.

*** This bug has been marked as a duplicate of bug 433059 ***
Comment 7 Paul McAuley 2021-04-01 16:44:34 UTC
OK, thanks for explaining. Though at a first glance I wouldn't have a clue what were meant by the "header". Perhaps if, as you have suggested, the titlebar colour options are to be hidden in the UI when a header is present, you could label the header something along the lines of "Header (titlebar + tools area)" so you can still find the titlebar colour.

Also, if that is the intentional appearance, I still think it could do with some more differentiation between active and inactive windows with different titlebar text colours. (in comment 2 I accidentally said titlebar colour when I meant titlebar text colour)
Comment 8 Nate Graham 2021-04-01 18:29:56 UTC
We tried our best to improve the differentiation in other ways to make up for the small delta between the active and inactive colors. That's why the clode button turns red for the active window, and its window shadow gets stronger. But I understand if you feel that it isn't enough. If you don't like it, you're welcome to switch back to the old Breeze color scheme, which is still shipped and supported.