Bug 434855 - No command-line argument to open with the specified device
Summary: No command-line argument to open with the specified device
Status: RESOLVED FIXED
Alias: None
Product: partitionmanager
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Andrius Štikonas
URL:
Keywords:
Depends on:
Blocks: 446897
  Show dependency treegraph
 
Reported: 2021-03-24 01:00 UTC by Nate Graham
Modified: 2021-12-12 21:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 22.04


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-03-24 01:00:20 UTC
All KDE software built from git master today.

I'd like to contribute .desktop files that allow Partition Manager actions tor a device or partition to appear in the Disks & Devices Plasma applet, to improve the integration between them. But to do this, you would need to be able to give the partitionmanager binary an argument corresponding to a device or a volume, since the system executes a command with the form of `[app] [argument corresponding to the device or volume]`. The binary currently accept no arguments like this. It looks like you used to be able to do this in an older version, but I tried using it and it did not work.
Comment 1 Andrius Štikonas 2021-03-24 01:20:06 UTC
Yes, it was possible but not anymore.

Some kind of filtering on device has to be implemented here:
https://invent.kde.org/system/kpmcore/-/blob/master/src/plugins/sfdisk/sfdiskbackend.cpp#L66

There is a reason why it was removed. When we had it, it was using Solid filter to find devices. Solid was actually just abstracting away udisks, but abstraction was not good enough and broke when udisks2 was released (which I think resulted in not being able to detect devices without partition table). So at that time partition manager switched from Solid to its own device scanner.

And non-working filtering command line argument was removed a bit later, I guess that's why you tried it and it did not work.
Comment 2 Nate Graham 2021-03-24 01:49:03 UTC
Interesting history, thanks.
Comment 3 Nate Graham 2021-12-04 03:38:35 UTC
Fixed by Tomaz Canabrava with https://invent.kde.org/system/partitionmanager/-/commit/479c3f4678ba95b2dc28cb28b7be93430cbec3de in 22.04!