Bug 434805 - Additional header appears if more than one device is mounted
Summary: Additional header appears if more than one device is mounted
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Disks & Devices (show other bugs)
Version: 5.21.3
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-23 00:01 UTC by popov895
Modified: 2021-07-18 16:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments
Additional header (269.77 KB, image/png)
2021-03-23 00:01 UTC, popov895
Details

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2021-03-23 00:01:57 UTC
Created attachment 136960 [details]
Additional header

SUMMARY

If more than one device is mounted, an additional header appears, which contains a button to safely remove all mounted devices. It looks like this button needs to be replaced with a similar action in the hamburger menu.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: openSUSE Tumbleweed 20210320 / X11
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-03-23 13:03:54 UTC
Cannot confirm, but this appears to be another bug because I can't get the "Remove All" button to show up at all, so it suppresses the header.

Will investigate.
Comment 2 Nate Graham 2021-03-23 14:16:43 UTC
I cannot find anything in the code that adds a second piece of header text, so I assume this was fixed for 5.22 already. As for the second bar with the button on it, this is intentional, to make sure that 1) the button has text so that people know what it does, and 2) it does not get pushed into the hamburger menu where people would probably never find it.

However while investigating, I found a few other bugs which I will fix momentarily. :)
Comment 3 Nate Graham 2021-07-18 16:12:04 UTC
Git commit 8a1217fc0e2746088f796d73e506e9a29eea1a07 by Nate Graham, on behalf of Eugene Popov.
Committed on 18/07/2021 at 16:10.
Pushed by ngraham into branch 'master'.

Add action to unmount all devices

This patch adds an action to unmount all mounted devices. Also it fixes the issue where an additional header appears if more than one device is mounted.

M  +9    -0    applets/devicenotifier/package/contents/ui/DeviceItem.qml
M  +7    -0    applets/devicenotifier/package/contents/ui/devicenotifier.qml

https://invent.kde.org/plasma/plasma-workspace/commit/8a1217fc0e2746088f796d73e506e9a29eea1a07