Bug 434717 - Pointless popup opens when I trigger Touchpad applet via keyboard shortcut
Summary: Pointless popup opens when I trigger Touchpad applet via keyboard shortcut
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Touchpad (show other bugs)
Version: master
Platform: Neon Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-03-21 12:36 UTC by Patrick Silva
Modified: 2021-05-18 18:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments
screenshot (13.39 KB, image/png)
2021-03-21 12:36 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-03-21 12:36:42 UTC
Created attachment 136914 [details]
screenshot

STEPS TO REPRODUCE
1. enable Touchpad applet in system tray
2. assign a keyboard shortcut in the setiings of Touchpad applet
3. trigger the Touchpad applet by pressing its keyboard shortcut

OBSERVED RESULT
state of the touchpad changes as expected and "Touchpad" popup immediately opens.
See the attached screenshot please.
This pointless popup does not open when I trigger Touchpad applet with mouse or touchscreen.

EXPECTED RESULT
Touchpad applet should work in the same way regardless how it is triggered
(mouse, touchscreen, keyboard shorctut).

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.21.80
KDE Frameworks Version: 5.81.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Nate Graham 2021-03-21 13:30:05 UTC
Can confirm.
Comment 2 Bug Janitor Service 2021-05-07 20:56:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/455
Comment 3 Nate Graham 2021-05-18 18:17:04 UTC
Git commit 3b4026641454c02ad3030c8cd2134a672995ffa9 by Nate Graham.
Committed on 18/05/2021 at 18:15.
Pushed by ngraham into branch 'master'.

Delete the Touchpad applet

Ths only thing this applet can do is disable or re-enable your
touchpad. If you have no touchpad, it is pointless. If you have only a
touchpad and no mouse, then the only thing it can do is give you a way
to brick your laptop until you find a mouse you can use to re-enable
the touchpad.

The only conceivable non-catastrophic usage of this applet is to
manually disable a laptop's touchpad when a mouse is plugged in. This is
an extremely niche use case that can already be accomplished by using
the "Toggle Touchpad" keyboard shortcut which is exported by the KCM,
and would be better served by a setting in the touchpad KCM itself to
automatically disable the touchpad when a mouse is plugged in and
re-enable it when unplugged, should such a feature be deemed useful. I
have my doubts, as Libinput has gotten very good at ignoring false input
these days, so I think there is no longer much of a use case for
disabling a touchpad at all.

Overall, this applet is not worth the bugs and degradation of the user
experience that it can cause. It is too dangerous to exist. Let's delete
it.
Related: bug 434720, bug 434718, bug 397210, bug 378879, bug 430029
FIXED-IN: 5.23

M  +1    -1    kcms/touchpad/CMakeLists.txt
D  +0    -155  kcms/touchpad/applet/qml/contents/ui/touchpad.qml
D  +0    -160  kcms/touchpad/applet/qml/metadata.desktop
D  +0    -30   kcms/touchpad/applet/touchpad.svg
R  +4    -12   kcms/touchpad/dataengine/CMakeLists.txt [from: kcms/touchpad/applet/CMakeLists.txt - 065% similarity]
R  +0    -0    kcms/touchpad/dataengine/plasma-dataengine-touchpad.desktop [from: kcms/touchpad/applet/plasma-dataengine-touchpad.desktop - 100% similarity]
R  +0    -0    kcms/touchpad/dataengine/touchpad.operations [from: kcms/touchpad/applet/touchpad.operations - 100% similarity]
R  +0    -0    kcms/touchpad/dataengine/touchpadengine.cpp [from: kcms/touchpad/applet/touchpadengine.cpp - 100% similarity]
R  +0    -0    kcms/touchpad/dataengine/touchpadengine.h [from: kcms/touchpad/applet/touchpadengine.h - 100% similarity]
R  +0    -0    kcms/touchpad/dataengine/touchpadservice.cpp [from: kcms/touchpad/applet/touchpadservice.cpp - 100% similarity]
R  +0    -0    kcms/touchpad/dataengine/touchpadservice.h [from: kcms/touchpad/applet/touchpadservice.h - 100% similarity]

https://invent.kde.org/plasma/plasma-desktop/commit/3b4026641454c02ad3030c8cd2134a672995ffa9