Bug 434577 - Add support for Zstandard
Summary: Add support for Zstandard
Status: RESOLVED FIXED
Alias: None
Product: frameworks-karchive
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-18 11:33 UTC by alan.n.davies
Modified: 2021-04-10 02:12 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description alan.n.davies 2021-03-18 11:33:45 UTC
SUMMARY
I submitted a bug report for ark because it could not open a single file that has been compressed by ZStandard...
https://bugs.kde.org/show_bug.cgi?id=434540

They suggested I raise a feature request for frameworks-karchive to support Zstandard

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux 11 (bullseye/testing)
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2
Comment 1 Bug Janitor Service 2021-03-29 22:19:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/karchive/-/merge_requests/10
Comment 2 Albert Astals Cid 2021-04-09 08:01:08 UTC
Git commit de2861eb1ac646d14ba71299c2f6969bbd70a212 by Albert Astals Cid.
Committed on 08/04/2021 at 21:44.
Pushed by dfaure into branch 'master'.

Implement KZstdFilter

M  +7    -1    CMakeLists.txt
M  +8    -0    autotests/CMakeLists.txt
M  +4    -0    autotests/karchivetest.cpp
M  +11   -0    autotests/kcompressiondevicetest.cpp
M  +1    -0    autotests/kcompressiondevicetest.h
M  +24   -0    autotests/kfiltertest.cpp
M  +1    -0    autotests/kfiltertest.h
M  +6    -0    src/CMakeLists.txt
M  +3    -0    src/config-compression.h.cmake
M  +7    -0    src/kcompressiondevice.cpp
M  +1    -0    src/kcompressiondevice.h
M  +10   -0    src/kfilterdev.cpp
M  +4    -0    src/ktar.cpp
A  +132  -0    src/kzstdfilter.cpp     [License: LGPL(v2.0+)]
A  +54   -0    src/kzstdfilter.h     [License: LGPL(v2.0+)]

https://invent.kde.org/frameworks/karchive/commit/de2861eb1ac646d14ba71299c2f6969bbd70a212
Comment 3 Kurt Hindenburg 2021-04-09 13:16:08 UTC
This broke building on macOS 11.2.3

[ 96%] Linking CXX executable ../bin/kcompressiondevicetest
tar: Option --zstd is not supported
Usage:
  List:    tar -tf <archive-filename>
  Extract: tar -xf <archive-filename>
  Create:  tar -cf <archive-filename> [filenames...]
  Help:    tar --help

tar --version
bsdtar 3.3.2 - libarchive 3.3.2 zlib/1.2.11 liblzma/5.0.5 bz2lib/1.0.6
Comment 4 Albert Astals Cid 2021-04-09 22:47:41 UTC
Kurt, can you check if https://invent.kde.org/frameworks/karchive/-/merge_requests/12 helps?
Comment 5 Kurt Hindenburg 2021-04-10 02:12:42 UTC
It fixes the build - thanks.