Bug 434539 - No close or back button when viewing images in an application page
Summary: No close or back button when viewing images in an application page
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.21.2
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: junior-jobs, usability
Depends on:
Blocks:
 
Reported: 2021-03-17 10:56 UTC by Mohammed Sameer
Modified: 2021-03-19 13:20 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/discover/commit/e7d37b915d16ced14879b1d4a17b624fa542bffa
Version Fixed In: 5.22
Sentry Crash Report:

Attachments
Discover image view (334.06 KB, image/png)
2021-03-17 10:56 UTC, Mohammed Sameer 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Mohammed Sameer 2021-03-17 10:56:12 UTC 
Created attachment 136780 [details]
Discover image view

SUMMARY
No close or back button when viewing images in an application page like krita.

STEPS TO REPRODUCE
1. open discover
2. click a listed application like krita
3. open images shown below app title

OBSERVED RESULT
The images shown does not have close or back button to close the opened image.

EXPECTED RESULT
The images shown have close or back button to close the opened image view.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.21
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Kernel Version: 5.4.0-67-generic
OS Type: 64-bit
Graphics Platform: X11
Processors: 4 × Intel® Core™ i3-5010U CPU @ 2.10GHz
Memory: 3.8 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 5500

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-03-17 23:37:15 UTC 
Confirmed.

You can just click on the grayed-out part of the rest of the window, but nobody ever figured this out; it was obvious only to the original authors of the popup component, I suspect. :)
Comment 2 Justin Zobel 2021-03-18 01:29:33 UTC 
Working on this. Fix coming today.
Comment 3 Justin Zobel 2021-03-18 02:48:13 UTC 
Merge request: https://invent.kde.org/plasma/discover/-/merge_requests/94
Comment 4 Bug Janitor Service 2021-03-18 21:54:40 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/95
Comment 5 Nate Graham 2021-03-18 22:59:21 UTC 
Git commit e7d37b915d16ced14879b1d4a17b624fa542bffa by Nate Graham, on behalf of Justin Zobel.
Committed on 18/03/2021 at 22:59.
Pushed by ngraham into branch 'master'.

Add close button to screenshot popup
FIXED-IN: 5.22

M  +10   -0    discover/qml/ApplicationScreenshots.qml

https://invent.kde.org/plasma/discover/commit/e7d37b915d16ced14879b1d4a17b624fa542bffa
Comment 6 Mohammed Sameer 2021-03-19 08:35:10 UTC 
Thanks.
Comment 7 Nate Graham 2021-03-19 13:20:55 UTC 
You're welcome!