Bug 434534 - Need to click "Accept" when pasting an image
Summary: Need to click "Accept" when pasting an image
Status: RESOLVED FIXED
Alias: None
Product: Ruqola
Classification: Applications
Component: frontend (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Laurent Montel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-17 09:32 UTC by Angel Docampo
Modified: 2021-03-17 14:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Angel Docampo 2021-03-17 09:32:02 UTC
SUMMARY
When pasting an image to the chat conversation, a modal window appears to put some description on the image, which may be of use for some people, but we need to click on the Accept button or pressing Tab up to that button. It's not quite user-friendly.

STEPS TO REPRODUCE
1. Copy to the clipboard an image
2. The Upload dialog appears with the temporary path already filled
3. Press Enter

OBSERVED RESULT
Nothing happens

EXPECTED RESULT
Focus should be on Accept button, instead of Description field, so a user can just paste the image and press enter, in most situations, is what a user wants. In this way, when this upload windows is presented, pressing Escape key will cancel, and Enter key will Accept.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
As the upload window is the same for normal file upload, Accept button should make sure first there are something on the File field.
Comment 1 Laurent Montel 2021-03-17 12:46:44 UTC
Git commit 25e6147d7de0065e6ff1b83e0bd95f4a6f19cbab by Laurent Montel.
Committed on 17/03/2021 at 12:38.
Pushed by mlaurent into branch 'master'.

Fix Bug 434534 - Need to click "Accept" when pasting an image

M  +0    -2    src/widgets/dialogs/uploadfilewidget.cpp

https://invent.kde.org/network/ruqola/commit/25e6147d7de0065e6ff1b83e0bd95f4a6f19cbab
Comment 2 Angel Docampo 2021-03-17 14:39:43 UTC
Confirmed, works perfect now.