Bug 434525 - Rendering Plus Button (New Tab)
Summary: Rendering Plus Button (New Tab)
Status: REPORTED
Alias: None
Product: yakuake
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-17 05:12 UTC by varlesh
Modified: 2021-03-18 16:44 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
arrow-down (14.68 KB, image/png)
2021-03-17 05:12 UTC, varlesh
Details
Render PNG (7.66 KB, image/png)
2021-03-17 05:14 UTC, varlesh
Details
Render SVG (7.66 KB, image/png)
2021-03-17 05:15 UTC, varlesh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description varlesh 2021-03-17 05:12:04 UTC
Created attachment 136765 [details]
arrow-down

After update to Yakuake 20.12.3 plus button have wrong rendering with SVG.
Also why need draw "arrow-down" icon on plus button? It's spoil all themes and Breeze too!!!
More info here: https://github.com/PapirusDevelopmentTeam/materia-kde/issues/108
Comment 1 varlesh 2021-03-17 05:14:14 UTC
Created attachment 136766 [details]
Render PNG
Comment 2 varlesh 2021-03-17 05:15:26 UTC
Created attachment 136767 [details]
Render SVG
Comment 4 varlesh 2021-03-17 05:25:40 UTC
Please tell me why this needed and why this draw over plus button?
https://github.com/KDE/yakuake/blob/master/app/tabbar.cpp#L985

m_dropIndicator->setPixmap(QIcon::fromTheme(QStringLiteral("arrow-down")).pixmap(arrowSize, arrowSize, drawMode));
Comment 5 Nate Graham 2021-03-18 16:44:36 UTC
I imagine to communicate to the user that they can press-and-hold the button to access more options. If the icon isn't positioned properly, that's a bug.