Bug 434517 - Remove redundant close button at the bottom of the preview window
Summary: Remove redundant close button at the bottom of the preview window
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: 20.12.3
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Elvis Angelaccio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-16 23:26 UTC by popov895
Modified: 2021-10-04 15:08 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/utilities/ark/commit/5e9c140e1ef9f7a7cad61b3889cf7f820dccf4f4
Version Fixed In: 21.12
Sentry Crash Report:

Attachments
Ark preview window (224.12 KB, image/png)
2021-03-16 23:26 UTC, popov895 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2021-03-16 23:26:45 UTC 
Created attachment 136757 [details]
Ark preview window

SUMMARY

Preview windows contain a redundant close button that duplicates the close button in the title bar. Also, removing this button will free up additional vertical space.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE neon 5.21 User Edition / X11
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Comment 1 Justin Zobel 2021-03-17 21:31:32 UTC 
Thanks for the suggestion, have moved to the wishlist section.
Comment 2 Bug Janitor Service 2021-10-01 14:55:43 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/utilities/ark/-/merge_requests/67
Comment 3 Bug Janitor Service 2021-10-01 14:55:45 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/utilities/ark/-/merge_requests/67
Comment 4 popov895 2021-10-01 16:36:23 UTC 
There is already a MR for this issue https://invent.kde.org/utilities/ark/-/merge_requests/60 (two months old).
Comment 5 Nate Graham 2021-10-04 15:08:13 UTC 
Git commit 5e9c140e1ef9f7a7cad61b3889cf7f820dccf4f4 by Nate Graham, on behalf of Eugene Popov.
Committed on 04/10/2021 at 15:08.
Pushed by ngraham into branch 'master'.

Remove redundant close button at the bottom of the preview window

This commit removes a redundant close button that duplicates the close
button in the title bar. Also, the preview window can be closed using
the keyboard shortcuts Ctrl+W / Alt+f4 / Esc.
FIXED-IN: 21.12

M  +4    -7    part/arkviewer.cpp
M  +1    -14   part/arkviewer.ui

https://invent.kde.org/utilities/ark/commit/5e9c140e1ef9f7a7cad61b3889cf7f820dccf4f4