Bug 434493 - The color scheme previews sometimes pull some colors from the active scheme
Summary: The color scheme previews sometimes pull some colors from the active scheme
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (show other bugs)
Version: 5.21.2
Platform: Other Linux
: HI normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 434787 435128 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-03-16 13:31 UTC by Reiddragon
Modified: 2021-03-31 17:42 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21.4
Sentry Crash Report:


Attachments
all previews pull the highlight and view and selection colors from Cinereus Blue (the active scheme) (96.37 KB, image/png)
2021-03-16 13:31 UTC, Reiddragon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Reiddragon 2021-03-16 13:31:55 UTC
Created attachment 136735 [details]
all previews pull the highlight and view and selection colors from Cinereus Blue (the active scheme)

SUMMARY
The colorscheme previews sometimes pull the View Background, View Text and Selection Background colors (possibly others as well) from the active scheme instead of the scheme being previewed

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT
check attachment

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2021-03-17 16:09:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/719
Comment 2 David Redondo 2021-03-22 08:54:41 UTC
Git commit 05426f6b7789ddfe634422d63852e97ec688b088 by David Redondo, on behalf of Arjen Hiemstra.
Committed on 22/03/2021 at 08:53.
Pushed by davidre into branch 'master'.

Fix color scheme preview

Set inherit to false in the root of the preview item.
Normally you would set ColorSet to View and be done with it, in this
case we need some additional custom stuff because of the custom palette.

M  +21   -6    kcms/colors/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/05426f6b7789ddfe634422d63852e97ec688b088
Comment 3 David Redondo 2021-03-22 08:57:23 UTC
Git commit 286edc6768e90d07947fad50db911f0c72e3759f by David Redondo, on behalf of Arjen Hiemstra.
Committed on 22/03/2021 at 08:56.
Pushed by davidre into branch 'Plasma/5.21'.

Fix color scheme preview

Set inherit to false in the root of the preview item.
Normally you would set ColorSet to View and be done with it, in this
case we need some additional custom stuff because of the custom palette.

(cherry picked from commit 05426f6b7789ddfe634422d63852e97ec688b088)

M  +21   -6    kcms/colors/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/286edc6768e90d07947fad50db911f0c72e3759f
Comment 4 Nate Graham 2021-03-22 19:29:59 UTC
*** Bug 434787 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2021-03-31 17:42:45 UTC
*** Bug 435128 has been marked as a duplicate of this bug. ***