Bug 434461 - Right sidebar content is cut off on the right side
Summary: Right sidebar content is cut off on the right side
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: 5.21.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-15 21:46 UTC by medin
Modified: 2021-04-19 18:58 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21.4


Attachments
image1 (100.03 KB, image/png)
2021-03-15 21:46 UTC, medin
Details
image2 (91.54 KB, image/png)
2021-03-15 21:47 UTC, medin
Details
image3 (87.88 KB, image/png)
2021-03-15 21:47 UTC, medin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2021-03-15 21:46:50 UTC
Created attachment 136709 [details]
image1

On laptop with 15.6" screen, with new monitor window maximized, when I enter "Edit Page" mode, I can't see some parts of the UI on right side, and there is no way to resize layout to see them. See attached images for more info.
Comment 1 medin 2021-03-15 21:47:13 UTC
Created attachment 136710 [details]
image2
Comment 2 medin 2021-03-15 21:47:31 UTC
Created attachment 136711 [details]
image3
Comment 3 Justin Zobel 2021-03-16 04:02:15 UTC
Confirmed on all 3.
Operating System: Solus 4.2
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Comment 4 David Redondo 2021-03-26 12:24:18 UTC
Git commit c53c1c7b139b47d20ba347ca01f90b217dbf04ae by David Redondo.
Committed on 26/03/2021 at 12:23.
Pushed by davidre into branch 'master'.

Fix scrollbar overlapping configuration page

The preferredWidth was to big because the scrollbar adds additional
padding in the internal hierachy of the page.
Also up the columnWidth otherwise we do not have enough space for
the wide mode of the formlayout inside the faceConfigUi.
FIXED-IN:5.21.4

M  +1    -1    src/main.qml
M  +1    -1    src/page/FaceConfigurationPage.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/c53c1c7b139b47d20ba347ca01f90b217dbf04ae
Comment 5 David Redondo 2021-03-26 12:28:45 UTC
Git commit 954282f9f618c08e23ac6d312ec79e8213aa2ee1 by David Redondo.
Committed on 26/03/2021 at 12:28.
Pushed by davidre into branch 'Plasma/5.21'.

Fix scrollbar overlapping configuration page

The preferredWidth was to big because the scrollbar adds additional
padding in the internal hierachy of the page.
Also up the columnWidth otherwise we do not have enough space for
the wide mode of the formlayout inside the faceConfigUi.
FIXED-IN:5.21.4

(cherry picked from commit c53c1c7b139b47d20ba347ca01f90b217dbf04ae)

M  +1    -1    src/main.qml
M  +1    -1    src/page/FaceConfigurationPage.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/954282f9f618c08e23ac6d312ec79e8213aa2ee1
Comment 6 medin 2021-04-18 21:33:42 UTC
Problem in image1 is still persistent with 5.21.4
Comment 7 Nate Graham 2021-04-19 18:37:42 UTC
I think that last issue is caused by the fact that QQC2 checkboxes don't elide or wrap their text when it's too long. We can work around that by making the sidebar wider or shortening the text (or urging translators to use shorter translations).

However I think ultimately we just need to fix that bug. Let's track that with Bug 435934.
Comment 8 Nate Graham 2021-04-19 18:57:42 UTC
Git commit d32b902de5e33b68d6bfd9ea870c9b03697fa26f by Nate Graham.
Committed on 19/04/2021 at 18:57.
Pushed by ngraham into branch 'master'.

fill width for long checkbox

No effect right now, but this is for in case we ever fix Bug 434461.

M  +1    -0    faces/facepackages/textonly/contents/ui/Config.qml

https://invent.kde.org/plasma/libksysguard/commit/d32b902de5e33b68d6bfd9ea870c9b03697fa26f
Comment 9 Nate Graham 2021-04-19 18:58:16 UTC
I mean  Bug 435934, of course... :/