Bug 434406 - Neutral user icon as avatar choice
Summary: Neutral user icon as avatar choice
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_users (show other bugs)
Version: 5.21.2
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2021-03-14 17:12 UTC by Massimiliano L
Modified: 2022-02-22 22:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.25


Attachments
"Choose File" button in user management (160.97 KB, image/png)
2021-04-15 13:43 UTC, Domenico Panella
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Massimiliano L 2021-03-14 17:12:01 UTC
In the current version, the default avatar is generated from the user initials. The preloaded alternatives offered to the user are either a set of Konqi drawings or some generic images. What I think is lacking is a "plain" user icon, as it was the case for older versions.

It could be nice to provide the user with one or more plain-looking avatar choices (or, as an alternative, access to the "Select Icon" tool within the avatar selection).

(Personally I would suggest defaulting to a plain icon as it looks more polished than the user initials, considering that the user full name is already displayed along with the avatar.)

SYSTEM
Linux/KDE Plasma: Fedora 33
(available in About System)
KDE Plasma Version:  5.21.2
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-03-17 23:01:02 UTC
Seems fair. The `user-identity` icon seems neutral enough.
Comment 2 Massimiliano L 2021-03-21 09:06:58 UTC
(In reply to Nate Graham from comment #1)
> Seems fair. The `user-identity` icon seems neutral enough.

Thanks for the feedback!

Should we just copy-paste the icon to the files of the user manager? Does the latter support SVG or a raster format is required?
Comment 3 Domenico Panella 2021-04-14 16:33:45 UTC
If i understand well, we want to replace the initial image which contains the initial letters  with the "user-identity" icon.
Do we want really to change this behaviour ?
Comment 4 Nate Graham 2021-04-14 18:54:01 UTC
Not changing the default, just adding this as an option.
Comment 5 Domenico Panella 2021-04-15 08:20:47 UTC
A question:

my system settings show both "Users" and "Users Manager".
"Users manager" already offers this option while we create a new user. You can choice your preferred image
from window dialog or browsing file system.

"Users" doesn't offer this option while we create the user (it always sets the image with initial letters) but only after do it we can change the image.

Do we want be able to choice our preferred image while create the user too on "Users"?
Comment 6 Massimiliano L 2021-04-15 08:41:33 UTC
(In reply to Domenico Panella from comment #5)
> A question:
> 
> my system settings show both "Users" and "Users Manager".
> "Users manager" already offers this option while we create a new user. You
> can choice your preferred image
> from window dialog or browsing file system.
> 
> "Users" doesn't offer this option while we create the user (it always sets
> the image with initial letters) but only after do it we can change the image.
> 
> Do we want be able to choice our preferred image while create the user too
> on "Users"?

I do not think this is a very useful feature for two reasons:
1. most systems have single user created during the installation, without access to customisations of the DE user profile;
2. if you are using "Users" to create an user, you are probably creating someone's else user so it does not makes sense to customise the profile picture for them.

(Coming back to the previous message I believe the "user-identity" icon would be a better default and give a more polished look. Initials currently appear right next to the user's full name and the background color of the circle makes up a bit of visual clutter. On the other hand this is also a matter of personal preference and I understand you/we may want to showcase this feature in the defaults :)
Comment 7 Massimiliano L 2021-04-15 08:50:00 UTC
> (Coming back to the previous message I believe the "user-identity" icon
> would be a better default and give a more polished look. Initials currently
> appear right next to the user's full name and the background color of the
> circle makes up a bit of visual clutter. On the other hand this is also a
> matter of personal preference and I understand you/we may want to showcase
> this feature in the defaults :)

P.S.: in favour of changing the default would be the fact that the initials-style avatar is currently buggy (see bug 434407), so as soon as the user tries to change the default appearance (e.g. color) the avatar will look 'bad'.
Comment 8 Domenico Panella 2021-04-15 09:50:06 UTC
First of all, i understand the reason which i had both "User Manager" and "User". It seems that the user-manager ("User manager") package is no longer required now. Both provide the same functionality (with little difference), therefore is useless.

Coming back to the question, "User" already provides this possibilty only in modify mode, not insert mode.
If we are creating a new user (not myself), it has not sense to have this functionality at creation time too.

I had properly interpreted your request therefore you are requiring a default behaviour changing which should show "user-identity" icon in place of image with initial letters which you say that is buggy too when we change its aspect.

To be honest, for me is indiffeent, but from comment above, it doesn't seem interested to change it, therefore i'd say to close this bug/request.
I'd leave open this  bug 434407 instead
Comment 9 Massimiliano L 2021-04-15 10:14:28 UTC
(In reply to Domenico Panella from comment #8)
> I had properly interpreted your request therefore you are requiring a
> default behaviour changing which should show "user-identity" icon in place
> of image with initial letters which you say that is buggy too when we change
> its aspect.
> 
> To be honest, for me is indiffeent, but from comment above, it doesn't seem
> interested to change it, therefore i'd say to close this bug/request.
> I'd leave open this  bug 434407 instead

I think this was clear from my opening message that my primary aim was to have/provide a neutral-looking option such as the user identity icon among the avatar choices. This can be done pretty easily (I can try to do it by myself and file a merge request).

The change of defaults was just a sidenote suggestion given the current state of things but it can be put aside if nobody else supports it (also I guess these matters should be up to the VDG?).
Comment 10 Domenico Panella 2021-04-15 11:45:41 UTC
(In reply to Massimiliano L from comment #9)
> (In reply to Domenico Panella from comment #8)
> > I had properly interpreted your request therefore you are requiring a
> > default behaviour changing which should show "user-identity" icon in place
> > of image with initial letters which you say that is buggy too when we change
> > its aspect.
> > 
> > To be honest, for me is indiffeent, but from comment above, it doesn't seem
> > interested to change it, therefore i'd say to close this bug/request.
> > I'd leave open this  bug 434407 instead
> 
> I think this was clear from my opening message that my primary aim was to
> have/provide a neutral-looking option such as the user identity icon among
> the avatar choices. This can be done pretty easily (I can try to do it by
> myself and file a merge request).
> 
> The change of defaults was just a sidenote suggestion given the current
> state of things but it can be put aside if nobody else supports it (also I
> guess these matters should be up to the VDG?).

Yes, but where shoud be added this option ? During user creation is not is possible and i think that it's intentional
(In reply to Massimiliano L from comment #9)
> (In reply to Domenico Panella from comment #8)
> > I had properly interpreted your request therefore you are requiring a
> > default behaviour changing which should show "user-identity" icon in place
> > of image with initial letters which you say that is buggy too when we change
> > its aspect.
> > 
> > To be honest, for me is indiffeent, but from comment above, it doesn't seem
> > interested to change it, therefore i'd say to close this bug/request.
> > I'd leave open this  bug 434407 instead
> 
> I think this was clear from my opening message that my primary aim was to
> have/provide a neutral-looking option such as the user identity icon among
> the avatar choices. This can be done pretty easily (I can try to do it by
> myself and file a merge request).

During user creation is not is possible and i think that it's intentional...
It has not sense to add a profile picture for the user which you are not. 
In modify mode, it already provides this functionality and it's right , therefore, 
you only could ask a default behaviour changing which doesn't seem wanted.
 
> The change of defaults was just a sidenote suggestion given the current
> state of things but it can be put aside if nobody else supports it (also I
> guess these matters should be up to the VDG?).

Probably, you are right
Comment 11 Domenico Panella 2021-04-15 11:48:22 UTC
Sorry, for typed errors ;)
Comment 12 Massimiliano L 2021-04-15 13:05:49 UTC
> During user creation is not is possible and i think that it's intentional...
> It has not sense to add a profile picture for the user which you are not. 
> In modify mode, it already provides this functionality and it's right ,
> therefore, 
> you only could ask a default behaviour changing which doesn't seem wanted.

Yes, my point is that in "edit mode" there is a pool of images that can be chosen from. If I remember correctly, the old user manager had access to the icon set. The new user manager has access to a pre-defined set of images and it is just a matter of adding one more to the repo :)
Comment 13 Domenico Panella 2021-04-15 13:42:36 UTC
(In reply to Massimiliano L from comment #12)
> > During user creation is not is possible and i think that it's intentional...
> > It has not sense to add a profile picture for the user which you are not. 
> > In modify mode, it already provides this functionality and it's right ,
> > therefore, 
> > you only could ask a default behaviour changing which doesn't seem wanted.
> 
> Yes, my point is that in "edit mode" there is a pool of images that can be
> chosen from. If I remember correctly, the old user manager had access to the
> icon set. The new user manager has access to a pre-defined set of images and
> it is just a matter of adding one more to the repo :)

You can choice whatever image you want via browsing file system with new user management too
(In reply to Massimiliano L from comment #12)
> > During user creation is not is possible and i think that it's intentional...
> > It has not sense to add a profile picture for the user which you are not. 
> > In modify mode, it already provides this functionality and it's right ,
> > therefore, 
> > you only could ask a default behaviour changing which doesn't seem wanted.
> 
> Yes, my point is that in "edit mode" there is a pool of images that can be
> chosen from. If I remember correctly, the old user manager had access to the
> icon set. The new user manager has access to a pre-defined set of images and
> it is just a matter of adding one more to the repo :)

Also the new user management predict the image/icons selection via file system browsing. You can select whatever you want via "Choose file" button.
Attach a screenshot to remove some doubts
Comment 14 Domenico Panella 2021-04-15 13:43:47 UTC
Created attachment 137633 [details]
"Choose File" button in user management
Comment 15 Massimiliano L 2021-04-15 15:11:38 UTC
(In reply to Domenico Panella from comment #13)
> Also the new user management predict the image/icons selection via file
> system browsing. You can select whatever you want via "Choose file" button.
> Attach a screenshot to remove some doubts

I think we are overcomplicating this :) I am aware "Choose file" option but that means the user would have either to find out where the icons are stored or download a custom image from the web. I do not see any problem in expanding the pool of available images by one element. I offer to take care of it.
Comment 16 Nate Graham 2021-04-15 15:29:42 UTC
Yeah, go ahead and submit the merge request. One more thing seems totally harmless to me.
Comment 17 Domenico Panella 2021-04-15 15:58:51 UTC
(In reply to Massimiliano L from comment #15)
> (In reply to Domenico Panella from comment #13)
> > Also the new user management predict the image/icons selection via file
> > system browsing. You can select whatever you want via "Choose file" button.
> > Attach a screenshot to remove some doubts
> 
> I think we are overcomplicating this :) I am aware "Choose file" option but
> that means the user would have either to find out where the icons are stored
> or download a custom image from the web. I do not see any problem in
> expanding the pool of available images by one element. I offer to take care
> of it.

In fact, there was only a misunderstanding. ;)
Anyway, when the changes are simple, you create the MR directly.
Sometimes we lose more time to write the problem than resolve it.
No problem if i have to do this MR.
Comment 18 Bug Janitor Service 2022-02-17 15:55:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1468
Comment 19 Nate Graham 2022-02-22 22:25:01 UTC
Git commit 7bc619b9ce51505bd0a7727cd08b42dd1ee325c6 by Nate Graham, on behalf of Janet Blackquill.
Committed on 22/02/2022 at 22:24.
Pushed by ngraham into branch 'master'.

kcms/users: offer plain user icon as avatar choice
FIXED-IN: 5.25

M  +119  -20   kcms/users/package/contents/ui/UserDetailsPage.qml

https://invent.kde.org/plasma/plasma-workspace/commit/7bc619b9ce51505bd0a7727cd08b42dd1ee325c6