Bug 434345 - If opening KCM from external source while System Settings is already open, subcategory sidebar list is not hidden when needed
Summary: If opening KCM from external source while System Settings is already open, su...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: 5.21.2
Platform: Other Linux
: HI minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 438609 449495 459060 459942 484150 486511 488018 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-03-12 23:20 UTC by slartibart70
Modified: 2024-06-26 13:22 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.2
Sentry Crash Report:


Attachments
screenshot (202.26 KB, image/png)
2021-03-12 23:20 UTC, slartibart70
Details

Note You need to log in before you can comment on or make changes to this bug.
Description slartibart70 2021-03-12 23:20:30 UTC
Created attachment 136634 [details]
screenshot

open systemsettings5
click on topic 'applications'
We now have two panels in two rows: 'applications' and the neighboring panel with additional info (depending on the selection of the 'applications' panel entries)

Leave it open in this state

Now right-click on the networks icon (neighboring the clock) in the system-tray

The already open systemsettings panel now opens the 'connections' info panel.
BUT:
This happens neighboring to the already displayed 'applications' panel... this is plain wrong.

see attached screenshot.

I have the impression, this happens on any item in systemsettings having a 'second' panel (hierarchy) when clicking on the entry (did not test all, though)
Comment 1 Nate Graham 2021-03-15 23:11:14 UTC
Can reproduce.
Comment 2 Nate Graham 2021-08-05 00:40:49 UTC
*** Bug 438609 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2022-02-03 18:50:31 UTC
*** Bug 449495 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2022-09-13 22:01:59 UTC
*** Bug 459060 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2022-10-10 02:22:39 UTC
*** Bug 459942 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2024-04-11 20:56:59 UTC
*** Bug 484150 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2024-05-03 19:12:09 UTC
*** Bug 486511 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2024-05-20 16:21:59 UTC
It looks like this was fixed by the same change that fixed Bug 446288, which was done by Nicolas Fella and will be available in Plasma 6.0.5!
Comment 9 Nate Graham 2024-06-11 20:13:05 UTC
Nope, not fixed, my mistake.
Comment 10 Nate Graham 2024-06-11 20:13:21 UTC
*** Bug 488018 has been marked as a duplicate of this bug. ***
Comment 11 Martin Riethmayer 2024-06-12 08:34:07 UTC
Since I misread this and thought it actually was fixed, just a quick clarification:
The title of the bug is correct. However, the steps to reproduce (as in the original report) no longer actually expose the bug. This is due to the fact that the network settings also shows 2 columns (and thus there is no need to hide the second column). The content of the second column is swapped out correctly.

New steps to reproduce
1.) Open Systemsettings
2.) Click on first level entry with an arrow (e.g. "Mouse & Touchpad" or "Keyboard"). A second column for that entry is displayed (e.g. for "Mouse & Touchpad" there will now be a column "Mouse", "Touchpad", "Screen edges")
3.) Right-click printer-ion in the panel (next to the clock, set it to show if it isn't currently visible) and select "Configure printers"

Expected Result:
Systemsettings should only show 1 column and the rest of the window should be the printer settings page.

Actual Result:
Systemsettings shows the second column that was previously shown.
Comment 12 Bug Janitor Service 2024-06-25 11:23:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/319
Comment 13 Nate Graham 2024-06-26 13:19:54 UTC
Git commit ab8a47509e38b4a7709266cf59114ef4b35dae1c by Nate Graham, on behalf of Mathias Tillman.
Committed on 26/06/2024 at 13:19.
Pushed by ngraham into branch 'master'.

Fix sub-category view remaining visible when moving to a top-level KCM

This fixes an issue where the sub-category view would still be visible
when opening a different kcm that is at the top level.

For example, if you did:
- systemsettings kcm_mouse
- and then, while System Settings is still open on that page did:
- systemsettings kcm_printer_manager

The sub category view on the left would still be on the Mouse & Touchpad
page. This commit fixes that by resetting the pageStack index to 0.
FIXED-IN: 6.1.2

M  +5    -0    app/qml/SubCategoryPage.qml

https://invent.kde.org/plasma/systemsettings/-/commit/ab8a47509e38b4a7709266cf59114ef4b35dae1c
Comment 14 Nate Graham 2024-06-26 13:22:08 UTC
Git commit 3b043fa20e83907cd8e642729ba388732f844892 by Nate Graham.
Committed on 26/06/2024 at 13:20.
Pushed by ngraham into branch 'Plasma/6.1'.

Fix sub-category view remaining visible when moving to a top-level KCM

This fixes an issue where the sub-category view would still be visible
when opening a different kcm that is at the top level.

For example, if you did:
- systemsettings kcm_mouse
- and then, while System Settings is still open on that page did:
- systemsettings kcm_printer_manager

The sub category view on the left would still be on the Mouse & Touchpad
page. This commit fixes that by resetting the pageStack index to 0.
FIXED-IN: 6.1.2


(cherry picked from commit ab8a47509e38b4a7709266cf59114ef4b35dae1c)

c1268bb2 Fix sub-category view still being visible when moving to a top-level kcm.
d4d87610 Pop the pageStack to ensure the sub-category view is not visible when moving...

Co-authored-by: Mathias Tillman <master.homer@gmail.com>

M  +5    -0    app/qml/SubCategoryPage.qml

https://invent.kde.org/plasma/systemsettings/-/commit/3b043fa20e83907cd8e642729ba388732f844892