SUMMARY The user can't cancel the colorize mask operation, which could generally be done when the user realizes they missed a particular stroke/color at the beginning of the intensive update operation. STEPS TO REPRODUCE 1. Make a stroke with the Colorize Mask tool. 2. Update. 3. Attempt to cancel it using the status bar. OBSERVED RESULT The progress indicator disappears on the status bar but operation doesn't stop. EXPECTED RESULT The operation should be cancelled. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Debian sid KDE Plasma Version: 5.20.5 KDE Frameworks Version: 5.78.0 Qt Version: 5.12.9 (Appimage) ADDITIONAL INFORMATION The progress indicator in the status bar does not align with the progress indicator in the layers docker.
I still have the exact same issue, when working on a big document I sometimes forget to enable "Limit to layer bounds" on the colorize tool (which should be enabled by default btw), and the operation can take about 3 minutes for a very small portion, without me able to do anything about it. This is a pretty annoying bug, would appreciate if there was a solution to it. SOFTWARE/OS VERSIONS Operating System: Arch Linux Kernel Version: 5.16.4-arch1-1 (64-bit) KDE Plasma Version: 5.23.5 KDE Frameworks Version: 5.90.0 Qt Version: 5.15.2 Krita version: 5.0.2
Git commit 801fe568faceb5ec87c667eb0c946083fc8580db by Dmitry Kazakov. Committed on 17/11/2022 at 11:04. Pushed by dkazakov into branch 'master'. Make Colorize Mask generation actually cancellable The patch introduces two things: 1) KisStrokeStrategy now has tryCancelCurrentStrokeJobAsync() method which is called before the jobs are actually cancelled. 2) KoUpdaterPrivate is fixed to actually cancel the action when it is placed in a different thread, not in the one KoProgressUpdater is. THIS CHANGE IS DANGEROUS! DON'T BACKPORT to Krita 5.1! M +7 -0 libs/image/kis_processing_visitor.cpp M +2 -0 libs/image/kis_processing_visitor.h M +2 -0 libs/image/kis_stroke.cpp M +5 -0 libs/image/kis_stroke_strategy.cpp M +7 -0 libs/image/kis_stroke_strategy.h M +13 -8 libs/image/lazybrush/KisWatershedWorker.cpp M +1 -0 libs/image/lazybrush/kis_colorize_mask.cpp M +13 -2 libs/image/lazybrush/kis_colorize_stroke_strategy.cpp M +1 -0 libs/image/lazybrush/kis_colorize_stroke_strategy.h M +10 -6 libs/widgetutils/KoProgressUpdater.h M +2 -3 libs/widgetutils/KoUpdater.cpp M +2 -1 libs/widgetutils/KoUpdater.h M +1 -1 libs/widgetutils/KoUpdaterPrivate_p.cpp M +0 -4 libs/widgetutils/KoUpdaterPrivate_p.h https://invent.kde.org/graphics/krita/commit/801fe568faceb5ec87c667eb0c946083fc8580db