Bug 434133 - The header doesn't disappear when using a global scheme with header colors, but overriding that with a color scheme without header colors
Summary: The header doesn't disappear when using a global scheme with header colors, b...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (show other bugs)
Version: 5.21.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-08 08:28 UTC by Reiddragon
Modified: 2022-02-16 00:32 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24
Sentry Crash Report:


Attachments
Header stays when using Breeze Dark globally and BreezeDracula for Kate alone (9.28 KB, image/png)
2021-03-08 08:28 UTC, Reiddragon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Reiddragon 2021-03-08 08:28:56 UTC
Created attachment 136480 [details]
Header stays when using Breeze Dark globally and BreezeDracula for Kate alone

SUMMARY
The header doesn't disappear when using a per app color scheme without header support if the global color scheme does support headers

STEPS TO REPRODUCE
1. Set a global colorscheme with header support (Breeze Light/Dark)
2. Set a per app color scheme without header support (tested with Kate and Breeze Dracula)
3. 

OBSERVED RESULT
The header stays using the color from the global color scheme (check attachment)

EXPECTED RESULT
The header should disappear the same way it does with global color schemes without header support

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-03-08 20:10:46 UTC
Did you restart your apps after applying these settings? If you do so, does the line disappear?
Comment 2 Reiddragon 2021-03-09 12:57:28 UTC
(In reply to Nate Graham from comment #1)
> Did you restart your apps after applying these settings? If you do so, does
> the line disappear?

Restarting does not make the header disappear
Comment 3 Nate Graham 2021-03-09 17:23:47 UTC
If you open your ~/.config/kdeglobals file, do you see sections in it with the titles:

[Colors:Header]

and

[Colors:Header][Inactive]
Comment 4 Reiddragon 2021-03-09 18:08:28 UTC
(In reply to Nate Graham from comment #3)
> If you open your ~/.config/kdeglobals file, do you see sections in it with
> the titles:
> 
> [Colors:Header]
> 
> and
> 
> [Colors:Header][Inactive]

Nope, there's nothing there

Setting a global color scheme that also doesn't support headers does fix it so I'm positive the issue is Breeze sees a header color in the global scheme and then doesn't bother checking if the app color scheme has a header color and if it doesn't it falls back to using the global color scheme's color for the header instead of hiding the header
Comment 5 Nate Graham 2021-03-09 23:30:59 UTC
Gotcha, thanks.

FWIW setting the global theme to Breeze Light and then setting the color scheme to Breeze (classic) gets rid of the line for me. I dunno why it would be not working for you.
Comment 6 Nate Graham 2022-02-16 00:32:53 UTC
This should be fixed now in Plasma 5.24.