Bug 433950 - disk usage of plasma systemmonitor should provide mount points as label
Summary: disk usage of plasma systemmonitor should provide mount points as label
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: 5.22.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-03-04 11:55 UTC by Till Schäfer
Modified: 2021-07-21 12:08 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23
Sentry Crash Report:


Attachments
screenshot of ambigious disk usage plasmoid (21.72 KB, image/png)
2021-03-04 11:55 UTC, Till Schäfer
Details
example of usefull description as shown in conky (2.16 KB, image/png)
2021-03-04 11:57 UTC, Till Schäfer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Till Schäfer 2021-03-04 11:55:23 UTC
Created attachment 136364 [details]
screenshot of ambigious disk usage plasmoid

In the current state of the Disk Usage Plasmoid, configured as text only, line chart, etc. The disks/partitions are only referenced by their total space. This is hard to distinguish, if one has multiple plartitions with the same size and even if each partition has a unique size, one needs to remember wich partiton has wich size in order to interpret the displayed values.

Thus, I propose to add the possibility to disk stats of mount points. I.e., I would like to see the disk usage of e.g., "/", "/var", and "/home" and have the labels showing this mount points.
Comment 1 Till Schäfer 2021-03-04 11:55:40 UTC
Operating System: Gentoo Linux
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Kernel Version: 5.10.18-gentoo
OS Type: 64-bit
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-4810MQ CPU @ 2.80GHz
Memory: 15.5 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4600
Comment 2 Till Schäfer 2021-03-04 11:57:02 UTC
Created attachment 136365 [details]
example of usefull description as shown in conky
Comment 3 David Redondo 2021-03-05 08:06:39 UTC
We decided to intentionally not show mount points as they are an technical detail.

This now shows the same names that are shown for example in the dolphin sidebar.
Comment 4 Till Schäfer 2021-03-05 08:38:25 UTC
I disagree and would like to argue, why I find this important. Feel free to close this bug again if you decide otherwise. If its useful, but you would not like to implement it, we may keep it open for feature contributors. Personally, I find the new widgets visually appealing and would like to replace my conky installation. However, in the current state the provided disk free information are just useless to me (see point 1).

1. Most important, as my example shows, one is unable to distinguish certain entries, which makes such entries nearly useless. 
2. You need to remember which partition has which size to interpret the displayed information. I would argue, that this is far more technical than mountpoints. 
3. If you do not know about mount points you are maybe better of with the overall summarized disk free space information. Furthermore, If you cant interpret mount points its useless to show the space utilization of certain partitions, since you do not know where to delete files / enlarge partitions / etc if a disk runs full. 
4. Dolphin is another use case:  In dolphin some partitions are probably not mounted. Thus, you cannot always attach useful information to such an sidebar entry (you actually have partial infos: some mount point, some partition labels). Furthermore, it is easy to evaluate in dolphin what the partition actually contains by clicking on the entry. 
5. Make it optional: If you still think, that mount points are not the right level of detail for some users, you may just add another type of disk sensors which show mountpoints, and keep the old style sensors. 
6. I would argue that device path are rather technical, but not mountpoints. I guess a user most likel knows about paths and subfolders.
Comment 5 Till Schäfer 2021-07-01 07:45:33 UTC
possibly related bug report Bug 410891
Comment 6 Till Schäfer 2021-07-01 09:12:15 UTC
(In reply to David Redondo from comment #3)
> We decided to intentionally not show mount points as they are an technical
> detail.
> 
> This now shows the same names that are shown for example in the dolphin
> sidebar.

This was changed recently (see the already linked Bug 410891)
Comment 7 Till Schäfer 2021-07-01 09:15:18 UTC
(In reply to Till Schäfer from comment #6)
> (In reply to David Redondo from comment #3)
> > We decided to intentionally not show mount points as they are an technical
> > detail.
> > 
> > This now shows the same names that are shown for example in the dolphin
> > sidebar.
> 
> This was changed recently (see the already linked Bug 410891)

It now shows the device name as additional info and the mount point as tool tip. The second change is hard to imagine for a widget. Thus, the solution here might look a bit different (actually showing mount points directly. maybe optional / configurable).
Comment 8 Bug Janitor Service 2021-07-08 10:14:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/174
Comment 9 Till Schäfer 2021-07-08 11:00:18 UTC
(In reply to Bug Janitor Service from comment #8)
> A possibly relevant merge request was started @
> https://invent.kde.org/plasma/libksysguard/-/merge_requests/174

Cool, I like this idea! 

This combined with some templates for naming might be a very good solution to this issue. With template I mean different naming schemes for the same sensor (e.g. fs size, mount point, device path).
Comment 10 David Redondo 2021-07-21 12:08:58 UTC
Git commit 5ce5e7e8456d4a3b456df8c0d5e6ff72d049eb00 by David Redondo.
Committed on 09/07/2021 at 12:44.
Pushed by davidre into branch 'master'.

Allow renaming of sensors

Users can now change the displayed name of sensors on a per face basis.
Saving/loading works the same as the sensor colors.
Resetting of the labels can be done by setting an empty label.
Related: bug 429157, bug 391500, bug 431552
FIXED-IN:5.23

M  +92   -31   faces/Choices.qml
M  +24   -0    faces/ConfigSensors.qml
M  +32   -0    faces/SensorFaceController.cpp
M  +10   -0    faces/SensorFaceController.h
M  +1    -0    faces/SensorFaceController_p.h
M  +1    -0    faces/facepackages/barchart/contents/ui/BarChart.qml
M  +3    -3    faces/facepackages/horizontalbars/contents/ui/FullRepresentation.qml
M  +1    -0    faces/facepackages/linechart/contents/ui/LineChart.qml
M  +1    -0    faces/facepackages/piechart/contents/ui/PieChart.qml
M  +2    -2    faces/facepackages/piechart/contents/ui/UsedTotalDisplay.qml
M  +1    -0    faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
M  +1    -0    faces/facepackages/textonly/contents/ui/FullRepresentation.qml
M  +3    -2    faces/facepackages/textonly/contents/ui/GroupedText.qml
M  +2    -2    faces/import/ExtendedLegend.qml
M  +24   -2    sensors/SensorDataModel.cpp
M  +10   -0    sensors/SensorDataModel.h

https://invent.kde.org/plasma/libksysguard/commit/5ce5e7e8456d4a3b456df8c0d5e6ff72d049eb00