Bug 433948 - Animations are not completely suppressed
Summary: Animations are not completely suppressed
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.21.1
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-04 10:49 UTC by medin
Modified: 2021-03-05 16:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2021-03-04 10:49:13 UTC
I disable all of animations and desktop effects and set animation speed to "Instant" in Plasma settings ans set Latency in Compositor to "Prefer lower latency", but in some apps like the new plasma monitor the right click menu inside Applications and Processes is showing fade effect, and Gnome disks, Gnome sound converter and Pamac are also showing animations when clicking on toolbars.

NB : There were some options to adjust animations in some places in Application style and Window Decorations but it seems they were removed. I don't know if that "Instant" option affect them or not.

Operating System: Manjaro Linux
KDE Plasma Version: 5.21.1
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Kernel Version: 5.4.100-1-MANJARO
OS Type: 64-bit
Comment 1 David Redondo 2021-03-04 15:01:20 UTC
Git commit ad2983e8b80b61d6047135d34b8cf5e209104137 by David Redondo.
Committed on 04/03/2021 at 11:20.
Pushed by ngraham into branch 'master'.

Respect the animation speed setting for menu open/close animation

150ms is the default value of shortDuration

M  +2    -2    org.kde.desktop/Menu.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/ad2983e8b80b61d6047135d34b8cf5e209104137
Comment 2 Nate Graham 2021-03-05 16:47:01 UTC
Git commit f5171d5a39735e298277f85400f2ee2246c28827 by Nate Graham.
Committed on 04/03/2021 at 15:55.
Pushed by ngraham into branch 'master'.

Use more standard duration values

This lets these durations be scaled or disabled according to the user's
preferences.

M  +6    -2    org.kde.desktop/BusyIndicator.qml
M  +2    -2    org.kde.desktop/Dialog.qml
M  +1    -1    org.kde.desktop/MenuBarItem.qml
M  +2    -2    org.kde.desktop/Popup.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/f5171d5a39735e298277f85400f2ee2246c28827
Comment 3 Nate Graham 2021-03-05 16:47:25 UTC
Git commit 177be0c79a9c32331e972fbcbf4182e40eea0fc3 by Nate Graham.
Committed on 05/03/2021 at 16:47.
Pushed by ngraham into branch 'master'.

Use more standard durations

Note that this also makes the busy indicator stop spinning at all when
the user has disabled animations. Instead it just shows a static image.

M  +5    -1    src/declarativeimports/plasmacomponents3/BusyIndicator.qml
M  +2    -2    src/declarativeimports/plasmacomponents3/Dialog.qml
M  +2    -2    src/declarativeimports/plasmacomponents3/Menu.qml
M  +2    -2    src/declarativeimports/plasmacomponents3/Popup.qml
M  +2    -2    src/declarativeimports/plasmacomponents3/ProgressBar.qml
M  +5    -1    src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml
M  +2    -2    src/declarativeimports/plasmastyle/ButtonStyle.qml
M  +2    -2    src/declarativeimports/plasmastyle/ComboBoxStyle.qml
M  +2    -2    src/declarativeimports/plasmastyle/ProgressBarStyle.qml
M  +2    -2    src/declarativeimports/plasmastyle/ToolButtonStyle.qml

https://invent.kde.org/frameworks/plasma-framework/commit/177be0c79a9c32331e972fbcbf4182e40eea0fc3
Comment 4 Nate Graham 2021-03-05 16:47:29 UTC
Git commit c22feb74e2b9e407461b20d0c80918e93044220d by Nate Graham.
Committed on 05/03/2021 at 16:47.
Pushed by ngraham into branch 'master'.

Use more standard duration values

This lets these durations be scaled or disabled according to the user's
preferences.

M  +1    -1    applets/analog-clock/contents/ui/Hand.qml
M  +1    -1    applets/devicenotifier/package/contents/ui/FullRepresentation.qml
M  +2    -1    applets/systemtray/package/contents/ui/items/PulseAnimation.qml
M  +1    -1    kcms/desktoptheme/package/contents/ui/Hand.qml
M  +3    -3    lookandfeel/contents/components/WallpaperFader.qml
M  +1    -1    lookandfeel/contents/desktopswitcher/DesktopSwitcher.qml
M  +1    -1    lookandfeel/contents/lockscreen/LockOsd.qml
M  +4    -4    lookandfeel/contents/lockscreen/LockScreenUi.qml
M  +8    -2    lookandfeel/contents/splash/Splash.qml
M  +1    -1    lookandfeel/contents/windowswitcher/WindowSwitcher.qml
M  +1    -1    sddm-theme/Main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/c22feb74e2b9e407461b20d0c80918e93044220d
Comment 5 Nate Graham 2021-03-05 16:47:33 UTC
Git commit 307acfcd8df00d1df90510876a7b9b176f6207d4 by Nate Graham.
Committed on 05/03/2021 at 16:47.
Pushed by ngraham into branch 'master'.

Use standard durations for global drawer animations

This way they can be scaled or disabled according to the user's
animation speed preferences.

M  +6    -6    src/controls/GlobalDrawer.qml

https://invent.kde.org/frameworks/kirigami/commit/307acfcd8df00d1df90510876a7b9b176f6207d4
Comment 6 Nate Graham 2021-03-05 16:47:39 UTC
Git commit 34b81ccb46119f0b9c3c02c4d509f7a62c0c80d8 by Nate Graham.
Committed on 05/03/2021 at 16:47.
Pushed by ngraham into branch 'master'.

Use more standard durations

This allows the animation speeds for these components to scale with the
user's preferences or be disabled entirely if they have turned off
animations.

M  +1    -1    desktoppackage/contents/views/Desktop.qml
M  +3    -3    kcms/activities/qml/privacyTab/BlacklistApplicationView.qml

https://invent.kde.org/plasma/plasma-desktop/commit/34b81ccb46119f0b9c3c02c4d509f7a62c0c80d8
Comment 7 Nate Graham 2021-03-05 16:47:48 UTC
Git commit 51940046c49566a8a6483b462f47f325aa310c7d by Nate Graham.
Committed on 05/03/2021 at 16:47.
Pushed by ngraham into branch 'master'.

Use more standard duration values

This lets these durations be scaled or disabled according to the user's
preferences. However we specifically do not want to use standard
scalable vaues for animated wallpaper pluguns like Hunyango and Haenau
which have their durations hardcoded for a reason.

M  +1    -1    applets/comic/package/contents/ui/ComicCentralView.qml
M  +1    -1    applets/comic/package/contents/ui/main.qml
M  +1    -1    applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml
M  +2    -2    applets/mediaframe/package/contents/ui/main.qml
M  +1    -1    applets/quickshare/plasmoid/contents/ui/main.qml
M  +4    -4    applets/timer/package/contents/ui/TimerView.qml
M  +1    -1    desktopswitchers/previews/contents/ui/main.qml
M  +4    -0    wallpapers/haenau/contents/ui/BackgroundElement.qml
M  +4    -0    wallpapers/haenau/contents/ui/BottomBackgroundElement.qml
M  +4    -0    wallpapers/haenau/contents/ui/RightBackgroundElement.qml
M  +4    -0    wallpapers/hunyango/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/51940046c49566a8a6483b462f47f325aa310c7d
Comment 8 Nate Graham 2021-03-05 16:48:39 UTC
Everything in Plasma and QML-baed apps now fully respects the animation duration settings, including not animating at all when animations are disabled.