Bug 433906 - New duplicate keyboard entry in system tray settings
Summary: New duplicate keyboard entry in system tray settings
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray widget (other bugs)
Version First Reported In: 5.21.1
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-03 12:14 UTC by medin
Modified: 2021-07-29 16:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.23
Sentry Crash Report:


Attachments
New duplicate keyboard entry in system tray settings (82.98 KB, image/png)
2021-03-03 12:14 UTC, medin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2021-03-03 12:14:39 UTC
Created attachment 136342 [details]
New duplicate keyboard entry in system tray settings

With 5.21, I see new keyboard entry in system tray settings, and it has no effect when enabled. See attached image for more info.
Comment 1 Konrad Materka 2021-03-03 16:55:20 UTC
@Andrey wasn't it fixed in Bug 430661?
Comment 2 Andrey 2021-03-03 17:11:55 UTC
As workaround, we only prevented autoloading of the new applet for X11, so that the two are not duplicating in systray by default.
The both applets are still presented and activatable in the systray settings, even simultaneously.
To activate new applet, one just need to set "Always shown" there.
Comment 3 Andrey 2021-03-03 17:22:31 UTC
Another words, it's just entries of two different things: old SNI widget and new applet. So they are not duplicated, they just named the same.

Should we rename the old one as "Keyboard Layout (legacy)" maybe?
If the naming is issue, maybe we should reopen this then. So feel free and thanks for reporting.
Comment 4 medin 2021-03-03 17:50:39 UTC
(In reply to Andrey from comment #3)
> Another words, it's just entries of two different things: old SNI widget and
> new applet. So they are not duplicated, they just named the same.
> 
> Should we rename the old one as "Keyboard Layout (legacy)" maybe?
> If the naming is issue, maybe we should reopen this then. So feel free and
> thanks for reporting.

For average user it's will always be bug and considered a duplication because user has no idea of the history of the changes being done. The best solution is to detect which desktop is used X11 or Wayland and show the correct keyboard entry. 
And from what I know desktop selection (X11 or Wayland) is done in SDDM login page before any applet is loaded, so there should be no problem in loading the correct applet corresponding to the selected desktop.
Comment 5 Andrey 2021-03-03 18:05:08 UTC
(In reply to medin from comment #4)
> The best
> solution is to detect which desktop is used X11 or Wayland and show the
> correct keyboard entry. 
They are both correct, and user is able to decide which one to display.
Eventually, the old one will be deleted when we reach feature parity.
Until then, I doubt something will cardinally change here.
Comment 6 Nate Graham 2021-03-03 18:34:57 UTC
The X11-specific one should simply never appear in the System Tray settings when on Wayland, and the Wayland-specific one should never appear in the System Tray settings on X11.
Comment 7 Nate Graham 2021-07-29 16:31:07 UTC
This should be fixed in Plasma 5.23