Bug 433898 - arm64: Handle sp, lr, fp as DwReg in CfiExpr
Summary: arm64: Handle sp, lr, fp as DwReg in CfiExpr
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-03 09:45 UTC by Mark Wielaard
Modified: 2021-03-04 18:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Handle sp, lr, fp as DwReg in CfiExpr (3.14 KB, text/plain)
2021-03-03 09:48 UTC, Mark Wielaard 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2021-03-03 09:45:32 UTC 
When copy_convert_CfiExpr_tree sees a DwReg on arm64 we simply call I_die_here;
This causes an issue in the case we really do have to handle that case (like in the testcase from https://bugzilla.redhat.com/show_bug.cgi?id=1923493).

Handle the stack pointer (sp), link register (x30) and frame pointer (x29), which we already keep in D3UnwindRegs, like we do for other architectures in evalCfiExpr and copy_convert_CfiExpr_tree.
Comment 1 Mark Wielaard 2021-03-03 09:48:31 UTC 
Created attachment 136337 [details]
Handle sp, lr, fp as DwReg in CfiExpr
Comment 2 Mark Wielaard 2021-03-04 18:36:35 UTC 
commit b92d30bb6de3aec40be9ad368f10f881e2b84ca7
Author: Mark Wielaard <mark@klomp.org>
Date:   Thu Mar 4 19:24:06 2021 +0100

    arm64: Handle sp, lr, fp as DwReg in CfiExpr
    
    When copy_convert_CfiExpr_tree sees a DwReg on arm64 we simply call
    I_die_here; This causes an issue in the case we really do have to handle
    that case (see https://bugzilla.redhat.com/show_bug.cgi?id=1923493).
    
    Handle the stack pointer (sp), link register (x30) and frame pointer (x29),
    which we already keep in D3UnwindRegs, like we do for other architectures
    in evalCfiExpr and copy_convert_CfiExpr_tree.
    
    https://bugs.kde.org/show_bug.cgi?id=433898