Bug 433881 - It's annoying when applying one of the Breeze global themes changes your Splash Screen or Task Switcher visualization
Summary: It's annoying when applying one of the Breeze global themes changes your Spla...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Theme packages (show other bugs)
Version: 5.23.4
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-03-02 22:00 UTC by medin
Modified: 2023-05-06 16:32 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2021-03-02 22:00:03 UTC
When I change the global theme, my task switcher changes to another (default breeze switcher is really slow), so I should go to another part in settings under "Window_Management>Task_Switcher" and change it back to what I had. I don't think that theme selection should control how switching between windows should be done, theme should only control how the switcher looks like.

NB : I'm happy that "Splash Screen", which suffers from the same problem, now is placed so close under "Appearance" node.
Comment 1 David Redondo 2021-03-03 08:15:49 UTC
Well global theme affects potentially everything

> I don't think that theme selection should control how switching between windows should be done, theme should only control how the switcher looks like.

That's exactly what's happening here
Comment 2 medin 2021-03-03 09:19:59 UTC
(In reply to David Redondo from comment #1)
> Well global theme affects potentially everything
> 
> > I don't think that theme selection should control how switching between windows should be done, theme should only control how the switcher looks like.
> 
> That's exactly what's happening here

No it's different, the default task switcher for breeze theme is slow vertical sidebar filled with thumbnails of opened apps, so if I set task switcher behavior to big icons then change my theme to another one then return to breeze theme, I will find that the task switcher is reset to breeze and not my old big icons.
Theme should change only the colors and the graphical looks of task switcher, and not how or where it should appears. It hard and annoying to always remember and find those hidden features that change with theme selection and there is no indication that they changed.
Comment 3 Nate Graham 2021-03-03 18:27:59 UTC
David is correct that the Global Theme only changes the visual representation of the switcher, not any of the behavioral settings in that KCM. However Medin is right that from a user perspective, changing the visualization effectively does change the behavior due to the different characteristics of the switchers. This is particularly true if you were using the Small Icons or Large Icons task switchers, which display icons rather than thumbnails. The interaction feels different.

FWIW this periodically annoys me too. I like the Large Icons task switcher, and every time I switch global themes to test something, I have to reset it back to what I want.

It's an easy fix: all we have to do is remove one item from the global theme definitions for Breeze, Breeze Dark, and Breeze Twilight. It remains to be seen whether this is the right solution though. Personally I think the best thing would be if the user gets shown what will happen when they apply a global theme, with the option to avoid applying any of the changes.
Comment 4 David Redondo 2021-03-04 07:43:09 UTC
I see that medin also doesn't like the change of splash screen. 
If you just want to change the colors, than you should switch the color theme and not the global theme.
Comment 5 Nate Graham 2021-03-04 14:04:46 UTC
Heh that annoys me too. :)

I think I'm in the same boat as Medin: the only two notable changes I make are to use the Large Icons task switcher, and disable the splash screen. Whenever I change global themes for any reason (typically testing patches or themes), I have to remember to reset these back to my own preferred settings.
Comment 6 Michal Kec (MiK) 2021-12-20 15:43:52 UTC
I agree with Nate here. 

Since there's a tree-structure menu "Appearance > Global Theme > *", I understand that a change of the global theme could change anything below. However task switcher configuration is placed under different menu - "Window Management" - thus this change is always confusing.
Comment 7 Nate Graham 2021-12-25 21:17:47 UTC
I tried changing the Breeze, Breeze Dark, and Breeze Twilight Global Themes to no longer change the current splash screen and window switcher, but that didn't really work either. In fact it became more annoying because switching to another Global Theme and back to one of those simply kept the other Global Theme's splash screen and window switcher, which was worse. What I think the three of us want is the ability to make *no* global theme mess with our current Splash Screen and Task Switcher choices.

I think the only way practical forward here is to allow the user to customize which settings a Global Theme would change at the moment it is applied apply it. Basically when you click the Apply button, a dialog like this would appear, telling you what changes will be made and letting you opt out of any of them:

> Do you want to allow the Global theme "$THEME_NAME" to change the following
> things from their current style to something else:
>   [x] Plasma style
>   [x] Icon theme
>   [x] Window switcher
>   [x] Splash screen


And so on. This is tracked by https://phabricator.kde.org/T11746, so let's continue the conversation there.
Comment 8 Nate Graham 2022-12-14 23:20:21 UTC
That work has been merged now, but this is still annoying by default as you have to remember to uncheck "apply task switcher." Re-opening.
Comment 9 Nate Graham 2023-05-06 16:32:30 UTC
Git commit e7bd1c29b29446665f50804fedb9a02312f4af53 by Nate Graham.
Committed on 06/05/2023 at 16:29.
Pushed by ngraham into branch 'master'.

Don't specify window switchers in our Global Themes

See https://invent.kde.org/plasma/plasma-desktop/-/issues/54 for details
and full discussion.

Closes https://invent.kde.org/plasma/plasma-desktop/-/issues/54
FIXED-IN: 6.0

M  +0    -3    lookandfeel/org.kde.breeze/contents/defaults
M  +0    -3    lookandfeel/org.kde.breezedark/contents/defaults
M  +0    -3    lookandfeel/org.kde.breezetwilight/contents/defaults

https://invent.kde.org/plasma/plasma-workspace/commit/e7bd1c29b29446665f50804fedb9a02312f4af53