Bug 433800 - Share:dataset "norest", task with rest (task 5 step 4)
Summary: Share:dataset "norest", task with rest (task 5 step 4)
Status: RESOLVED FIXED
Alias: None
Product: gcompris
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Jazeix Johnny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-01 17:13 UTC by Rolas
Modified: 2021-03-13 18:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
i select taskset noRest, but task is with rest (18.46 KB, image/jpeg)
2021-03-01 17:13 UTC, Rolas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rolas 2021-03-01 17:13:15 UTC
Created attachment 136289 [details]
i select taskset noRest, but task is with rest

I select the data set without rest, in task 5 in step 4 i get the task with rest
Comment 1 Rolas 2021-03-01 17:26:29 UTC
Task SHARE
Comment 2 Jazeix Johnny 2021-03-07 21:38:56 UTC
Thank you!
I've fixed it by adding 1 piece of candy to each boy by default, so we'll need to distribute 4 pieces of candy to each girl and 3 to each boy
Comment 4 Rolas 2021-03-08 08:45:02 UTC
does this code indicate that we will see a candy jar for residue?
with option "no rest" must not be visible candy jar:  "forceShowBasket": true,

 {
                "instruction": qsTr("Charles wants to share his 6 pieces of candy with 2 of his girl friends. Can he split the pieces of candy equally?"),
                "randomisedInputData": false,
                "totalBoys": 0,
                "totalGirls": 2,
                "totalCandies": 6,
                "forceShowBasket": true,
                "placedInGirls": 0,
                "placedInBoys": 0
            },
            {
                "instruction": qsTr("For her birthday, Elizabeth has 8 pieces of candy to share with 3 of her friends: 2 girls and 1 boy. How should she split the pieces of candy?"),
                "randomisedInputData": false,
                "totalBoys": 1,
                "totalGirls": 2,
                "totalCandies": 12,
                "forceShowBasket": true,
                "placedInGirls": 2,
                "placedInBoys": 0
            },
            {
                "instruction": qsTr("Jason's father gave him 16 pieces of candy to share with his friends: 2 boys and 2 girls. Help him give the pieces of candy to his friends."),
                "randomisedInputData": false,
                "totalBoys": 2,
                "totalGirls": 2,
                "totalCandies": 16,
                "forceShowBasket": true,
                "placedInGirls": 0,
                "placedInBoys": 0
            },
Comment 5 Emmanuel Charruau 2021-03-10 10:58:07 UTC
Hi,
When we spoke about adding this option, we wanted from a given difficulty level to have always a jar (the rest) present. We want to avoid users to conceive the following idea:
1- these is a jar = there will be a rest, I will try to find a result with a rest
2- no jar, no rest.
Hope this can help,
Emmanuel
Comment 6 Rolas 2021-03-10 11:18:18 UTC
(In reply to Emmanuel Charruau from comment #5)
> Hi,
> When we spoke about adding this option, we wanted from a given difficulty
> level to have always a jar (the rest) present. We want to avoid users to
> conceive the following idea:
> 1- these is a jar = there will be a rest, I will try to find a result with a
> rest
> 2- no jar, no rest.
> Hope this can help,
> Emmanuel

but when the user has selected the game level no rest,
it should not be a basket at that level (25 candy, 5 children, no rest)

I agree that we always need a basket on the second and third levels
(25 candy, 5 children, possible rest)
(30 candy, 5 children, possible rest)

Rolandas
Comment 7 Emmanuel Charruau 2021-03-10 11:32:50 UTC
You are right here.
Comment 8 Rolas 2021-03-13 16:45:14 UTC
(In reply to Emmanuel Charruau from comment #7)
> You are right here.

did i understand that

string 
"forceShowBasket": true,
in file
https://invent.kde.org/education/gcompris/-/blob/4fb141e9f7dc06b783070da2f9c1028e4b88226a/src/activities/share/resource/1/Data.qml
must be changed to 
"forceShowBasket": false,
(3x)?
Comment 9 Jazeix Johnny 2021-03-13 17:01:22 UTC
yes, we are doing it and it will be present in the release :)
Comment 10 Jazeix Johnny 2021-03-13 18:30:39 UTC
(In reply to Jazeix Johnny from comment #9)
> yes, we are doing it and it will be present in the release :)

Done in https://invent.kde.org/education/gcompris/-/commit/97f502c9c4e9af5cc481f65225c67f5291a6496a

Thank you for the report!