Bug 433755 - Focus effect for action buttons in Lock and Login screens is too subtle
Summary: Focus effect for action buttons in Lock and Login screens is too subtle
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.21.1
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-02-28 19:43 UTC by Lua
Modified: 2021-03-02 20:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22.3
Sentry Crash Report:


Attachments
SDDM (371.62 KB, video/mp4)
2021-02-28 19:43 UTC, Lua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lua 2021-02-28 19:43:26 UTC
Created attachment 136262 [details]
SDDM

SUMMARY


STEPS TO REPRODUCE
1. Lock your computer
2. Keep pressing tab, until the selection reaches to the session buttons

OBSERVED RESULT
The session buttons in the hover state in so subtle that is almost invisible. This also isn't great for accessibility.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.21
KDE Plasma Version: 5.21.1
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-03-02 17:58:57 UTC
Focus is indicated by an underline below the text. Unfortunately, the window size is so small that the text is cut off, so the opportunity to see he focus effect is lost as well.

We should probably use a more obvious focus effect.
Comment 2 Nate Graham 2021-03-02 20:31:44 UTC
Aha, the better focus effect was just broken. Fixing momentarily
Comment 3 Nate Graham 2021-03-02 20:33:26 UTC
Git commit 9882bee4b10046603a313a869c8eb352ea6c6727 by Nate Graham.
Committed on 02/03/2021 at 20:31.
Pushed by ngraham into branch 'master'.

[lookandfeel/ActionButton] Fix broken focus effect

It was broken because its visiblity was not bound to activeFocus
correctly. This would have broken in Qt6 anyway but fixing it now makes
the focus effect work as intended again.
FIXED-IN: 5.22.3

M  +1    -1    lookandfeel/contents/components/ActionButton.qml

https://invent.kde.org/plasma/plasma-workspace/commit/9882bee4b10046603a313a869c8eb352ea6c6727
Comment 4 Nate Graham 2021-03-02 20:34:17 UTC
Git commit 8fd7b38b66de36ad8b673f3ddb88f7810c4291cc by Nate Graham.
Committed on 02/03/2021 at 20:33.
Pushed by ngraham into branch 'Plasma/5.21'.

[lookandfeel/ActionButton] Fix broken focus effect

It was broken because its visiblity was not bound to activeFocus
correctly. This would have broken in Qt6 anyway but fixing it now makes
the focus effect work as intended again.
FIXED-IN: 5.22.3
(cherry picked from commit 9882bee4b10046603a313a869c8eb352ea6c6727)

M  +1    -1    lookandfeel/contents/components/ActionButton.qml

https://invent.kde.org/plasma/plasma-workspace/commit/8fd7b38b66de36ad8b673f3ddb88f7810c4291cc