Bug 433754 - Justify splitters take lot of space
Summary: Justify splitters take lot of space
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: git (master)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-28 19:22 UTC by xmilosobilic
Modified: 2021-02-28 23:24 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
latte layout example (12.71 KB, text/plain)
2021-02-28 19:22 UTC, xmilosobilic
Details
screenshots of latte dock (154.39 KB, application/gzip)
2021-02-28 20:30 UTC, xmilosobilic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description xmilosobilic 2021-02-28 19:22:33 UTC
Created attachment 136261 [details]
latte layout example

SUMMARY
Justify splitters take lot of space space

STEPS TO REPRODUCE
1. Set latte dock alignment to justify
2. add widgets to fill uo the dock, for example latte tasks and other stuff

OBSERVED RESULT
justify splitters stop reducing their size at one point and occupy unnecessary space

EXPECTED RESULT
justify splitters should reduce their size completely if other things are expanding, such as when adding icons to latte tasks

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Michail Vourlakos 2021-02-28 20:17:35 UTC
1. Show me a screenshot with what you consider an issue
2. In my system the observed issue that scrolling is activated without needed, is that what you mean?
Comment 2 xmilosobilic 2021-02-28 20:30:01 UTC
Created attachment 136265 [details]
screenshots of latte dock

on these screenshots is shown with red arrow thath "justify splitters" take very large unnecessary space and are unable to reduce when adding more tasks to latte-tasks, this started happening since recently not sure when, previously when latte tasks would be added more and more, they would expand all the way to that net widget on screenshot, but now as you can see for some reason justify splitters take a lot of constant space by default?
Comment 3 Michail Vourlakos 2021-02-28 20:37:38 UTC
it is not the justify splitters the issue. When you leave editmode, Justify splitters are calculated with 0 width. The issue is that Scrolling in Tasks does not produce a valid width. You can test it out by disabling the Scrolling in Tasks, you should notice that everything goes ok.
Comment 4 xmilosobilic 2021-02-28 20:44:04 UTC
I tried that already but the only result of that is me not being able to access those new opened tasks, splitters still take same space, this is really strange, not sure what kind of changes might have been introduced to splitters because i think this just started happening yesterday when i compiled the git version, until yesterday i was using latte-dock-git from arch linux aur repo which was little older i believe
Comment 5 Michail Vourlakos 2021-02-28 21:15:59 UTC
Git commit 37721a2628c4301ebec518fcddf5c8b42aedb2a0 by Michail Vourlakos.
Committed on 28/02/2021 at 21:12.
Pushed by mvourlakos into branch 'master'.

dont force margins for AutoFill applets

--this way the Tasks scrolling is not triggered
when no needed

M  +1    -1    containment/package/contents/ui/applet/ItemWrapper.qml
M  +2    -10   plasmoid/package/contents/ui/main.qml
M  +5    -18   plasmoid/package/contents/ui/taskslayout/ScrollableList.qml

https://invent.kde.org/plasma/latte-dock/commit/37721a2628c4301ebec518fcddf5c8b42aedb2a0
Comment 6 Michail Vourlakos 2021-02-28 21:17:24 UTC
fixed the scrolling issue... If you believe it should also extend at maximum please open a new bug report in order to not forget to support it in the future.
Comment 7 xmilosobilic 2021-02-28 21:48:58 UTC
I mean, for some reason i dont think we understood each other very good :D, scrolling was never the issue, i tried the new commit now but seems the issue is same, i mean for now ill probably just revert to some of the earlier commits when it was behaving differently, might be the issue with my configuration or something. thanks either way!
Comment 8 Michail Vourlakos 2021-02-28 23:04:50 UTC
Git commit b0cfb738bbb995cb28a77b32de8bb62e2eb5a87f by Michail Vourlakos.
Committed on 28/02/2021 at 23:04.
Pushed by mvourlakos into branch 'master'.

provide all available space to fillApplets

--in case there is a fill applet then give it all
remaining free space at all cases

M  +6    -2    containment/package/contents/ui/abilities/privates/LayouterPrivate.qml

https://invent.kde.org/plasma/latte-dock/commit/b0cfb738bbb995cb28a77b32de8bb62e2eb5a87f
Comment 9 Michail Vourlakos 2021-02-28 23:05:20 UTC
that should fix it for you I think
Comment 10 xmilosobilic 2021-02-28 23:24:50 UTC
Hey, it looks like this has fixed it..! Thanks for your effort awesome work..!