Bug 433715 - krunner crashes when input contains a quote
Summary: krunner crashes when input contains a quote
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: 5.21.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Lohnau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-27 19:27 UTC by Matthias Mueller
Modified: 2021-07-01 11:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Mueller 2021-02-27 19:27:29 UTC
SUMMARY
krunner crashes when you type a quotation mark into it. Was observed by me and another manjaro-user in an update-thread.

STEPS TO REPRODUCE
1. type a single ( ' ) or double quote ( " ) in krunner
2. observe crash ;)


SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.21.1
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

here are three core dumps from said other user:
Stack trace of thread 22637:
                                                     #0  0x00007f465480bc92 _ZN6KShell11tildeExpandERK7QString (libKF5CoreAddons.so.5 + 0x62c92)
                                                     #1  0x00007f463808a74b n/a (krunner_locations.so + 0x374b)
                                                     #2  0x00007f464c136ca8 _ZN6Plasma14AbstractRunner12performMatchERNS_13RunnerContextE (libKF5Runner.so.5 + 0xfca8)
                                                     #3  0x00007f464c141095 n/a (libKF5Runner.so.5 + 0x1a095)
                                                     #4  0x00007f464c114709 _ZN12ThreadWeaver8Executor3runERK14QSharedPointerINS_12JobInterfaceEEPNS_6ThreadE (libKF5ThreadWeaver.so.5 + 0x1a709)
                                                     #5  0x00007f464c113722 _ZN12ThreadWeaver3Job7executeERK14QSharedPointerINS_12JobInterfaceEEPNS_6ThreadE (libKF5ThreadWeaver.so.5 + 0x19722)
                                                     #6  0x00007f464c112fb1 _ZN12ThreadWeaver6Thread3runEv (libKF5ThreadWeaver.so.5 + 0x18fb1)
                                                     #7  0x00007f4653c51eff n/a (libQt5Core.so.5 + 0xcdeff)
                                                     #8  0x00007f46531e4299 start_thread (libpthread.so.0 + 0x9299)
                                                     #9  0x00007f46538d9053 __clone (libc.so.6 + 0xff053)
                                                     
                                                     Stack trace of thread 22640:
                                                     #0  0x00007f46531f09ba __futex_abstimed_wait_common64 (libpthread.so.0 + 0x159ba)
                                                     #1  0x00007f46531ea260 pthread_cond_wait@@GLIBC_2.3.2 (libpthread.so.0 + 0xf260)
                                                     #2  0x00007f4653c580c4 _ZN14QWaitCondition4waitEP6QMutex14QDeadlineTimer (libQt5Core.so.5 + 0xd40c4)
                                                     #3  0x00007f46548a8095 n/a (libQt5DBus.so.5 + 0x65095)
                                                     #4  0x00007f46548a8762 _ZN23QDBusPendingCallWatcher15waitForFinishedEv (libQt5DBus.so.5 + 0x65762)
                                                     #5  0x00007f464c13c40d n/a (libKF5Runner.so.5 + 0x1540d)
                                                     #6  0x00007f464c136ca8 _ZN6Plasma14AbstractRunner12performMatchERNS_13RunnerContextE (libKF5Runner.so.5 + 0xfca8)
                                                     #7  0x00007f464c141095 n/a (libKF5Runner.so.5 + 0x1a095)
                                                     #8  0x00007f464c114709 _ZN12ThreadWeaver8Executor3runERK14QSharedPointerINS_12JobInterfaceEEPNS_6ThreadE (libKF5ThreadWeaver.so.5 + 0x1a709)
                                                     #9  0x00007f464c113722 _ZN12ThreadWeaver3Job7executeERK14QSharedPointerINS_12JobInterfaceEEPNS_6ThreadE (libKF5ThreadWeaver.so.5 + 0x19722)
                                                     #10 0x00007f464c112fb1 _ZN12ThreadWeaver6Thread3runEv (libKF5ThreadWeaver.so.5 + 0x18fb1)
                                                     #11 0x00007f4653c51eff n/a (libQt5Core.so.5 + 0xcdeff)
                                                     #12 0x00007f46531e4299 start_thread (libpthread.so.0 + 0x9299)
                                                     #13 0x00007f46538d9053 __clone (libc.so.6 + 0xff053)
                                                     
                                                     Stack trace of thread 22636:
                                                     #0  0x00007f46538d3a9d syscall (libc.so.6 + 0xf9a9d)
                                                     #1  0x00007f4653c52256 _ZN11QBasicMutex12lockInternalEv (libQt5Core.so.5 + 0xce256)
                                                     #2  0x00007f4653c5808f _ZN14QWaitCondition4waitEP6QMutex14QDeadlineTimer (libQt5Core.so.5 + 0xd408f)
                                                     #3  0x00007f464c1117c1 _ZN12ThreadWeaver6Weaver36takeFirstAvailableJobOrSuspendOrWaitEPNS_6ThreadEbbb (libKF5ThreadWeaver.so.5 + 0x177c1)
                                                     #4  0x00007f464c115439 n/a (libKF5ThreadWeaver.so.5 + 0x1b439)
                                                     #5  0x00007f464c1108a3 _ZN12ThreadWeaver6Weaver12applyForWorkEPNS_6ThreadEb (libKF5ThreadWeaver.so.5 + 0x168a3)
                                                     #6  0x00007f464c115491 n/a (libKF5ThreadWeaver.so.5 + 0x1b491)
                                                     #7  0x00007f464c1108a3 _ZN12ThreadWeaver6Weaver12applyForWorkEPNS_6ThreadEb (libKF5ThreadWeaver.so.5 + 0x168a3)
                                                     #8  0x00007f464c115491 n/a (libKF5ThreadWeaver.so.5 + 0x1b491)
                                                     #9  0x00007f464c1108a3 _ZN12ThreadWeaver6Weaver12applyForWorkEPNS_6ThreadEb (libKF5ThreadWeaver.so.5 + 0x168a3)
                                                     #10 0x00007f464c115491 n/a (libKF5ThreadWeaver.so.5 + 0x1b491)
Comment 1 Alexander Lohnau 2021-02-27 19:46:16 UTC
Huh, this should have been fixed by https://invent.kde.org/plasma/plasma-workspace/-/commit/6c759a80506a3cfe0aba2b040d99d571894fecba

Apparently that did not make it in 5.21 in time :/
Comment 2 Matthias Mueller 2021-02-27 20:09:47 UTC
Fixed even before the bug report, excellent! :D
Comment 3 Alexander Lohnau 2021-02-27 22:35:44 UTC
Also has test cases, https://invent.kde.org/plasma/plasma-workspace/-/commit/0f01103ab81c8b39f458ade5bdfc258e95db52f9

But still sorry that this made it in production^^