Bug 433623 - Kdenlive extracts audio and overwrites files without warning!
Summary: Kdenlive extracts audio and overwrites files without warning!
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: 20.12.2
Platform: Microsoft Windows Microsoft Windows
: NOR critical
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-25 22:10 UTC by Larsen
Modified: 2021-02-26 15:24 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
kdenlive before (61.36 KB, image/png)
2021-02-25 22:10 UTC, Larsen
Details
kdenlive after (63.14 KB, image/png)
2021-02-25 22:11 UTC, Larsen
Details
files before (3.69 KB, image/png)
2021-02-25 22:11 UTC, Larsen
Details
files after (3.47 KB, image/png)
2021-02-25 22:11 UTC, Larsen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Larsen 2021-02-25 22:10:27 UTC
STEPS TO REPRODUCE
- Have a video in the Project Bin
- Have two different zones of it
- Have those zones in the timeline
- Extract audio for both zones
--> Audio clips are shown in the Project Bin with different durations
--> Check the location where the audio files have been created on disk and make a note of the date/time and size
- Extract audio of zone 1 again

OBSERVED RESULT
- Project Bin shows three audio clips all having the duration of zone 1
- Overwrites wav file from zone 2 without a warning. If you have made any changes to that file, those will be lost.


EXPECTED RESULT
kdenlive should show a warning when the file being exported to already exists that also states that changes will be lost.

SOFTWARE/OS VERSIONS
Windows 10

ADDITIONAL INFORMATION
I rated this bug critical as it isn't easily noticeable and can lead to a lot of data loss (as I learned the hard way). I edited some minutes of wave files to correct audio problems and only noticed this problem after some hours of work (as the correction had to be done manually for quite some positions).
Comment 1 Larsen 2021-02-25 22:10:53 UTC
Created attachment 136171 [details]
kdenlive before
Comment 2 Larsen 2021-02-25 22:11:06 UTC
Created attachment 136172 [details]
kdenlive after
Comment 3 Larsen 2021-02-25 22:11:26 UTC
Created attachment 136173 [details]
files before
Comment 4 Larsen 2021-02-25 22:11:37 UTC
Created attachment 136174 [details]
files after
Comment 5 Jean-Baptiste Mardelle 2021-02-26 14:43:33 UTC
Git commit a00d28ea502998dd707bbee996521de0743eed58 by Jean-Baptiste Mardelle.
Committed on 26/02/2021 at 14:43.
Pushed by mardelle into branch 'master'.

Transcode job: don't silently overwrite exported files.

M  +5    -6    src/jobs/transcodeclipjob.cpp

https://invent.kde.org/multimedia/kdenlive/commit/a00d28ea502998dd707bbee996521de0743eed58
Comment 6 Jean-Baptiste Mardelle 2021-02-26 15:24:16 UTC
Git commit f1cd744c5237f890bd779f37f73031ed38959199 by Jean-Baptiste Mardelle.
Committed on 26/02/2021 at 15:13.
Pushed by mardelle into branch 'release/20.12'.

Transcode job: don't silently overwrite exported files.

M  +5    -6    src/jobs/transcodeclipjob.cpp

https://invent.kde.org/multimedia/kdenlive/commit/f1cd744c5237f890bd779f37f73031ed38959199