Bug 433562 - Windows with intentionally missing/deactivated buttons do not display consistently with Aurorae decorations
Summary: Windows with intentionally missing/deactivated buttons do not display consist...
Status: CONFIRMED
Alias: None
Product: kwin
Classification: Plasma
Component: aurorae (show other bugs)
Version: 5.21.0
Platform: openSUSE Linux
: LO normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-24 23:03 UTC by Paul McAuley
Modified: 2023-09-06 10:52 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
A window with no maximize button displayed properly in Breeze binary decoration (634.05 KB, image/png)
2021-02-24 23:03 UTC, Paul McAuley
Details
A focused window with no maximize button displayed incorrectly in Kite aurorae decoration (626.75 KB, image/png)
2021-02-24 23:05 UTC, Paul McAuley
Details
An unfocused window with no maximize button displayed incorrectly in Kite aurorae decoration (567.38 KB, image/png)
2021-02-24 23:07 UTC, Paul McAuley
Details
Breeze binary decoration displaying window correctly without close button (734.89 KB, image/png)
2021-02-24 23:20 UTC, Paul McAuley
Details
A focused window with no close button displayed incorrectly in Kite aurorae decoration (626.75 KB, image/png)
2021-02-24 23:23 UTC, Paul McAuley
Details
An unfocused window with no close button displayed incorrectly in Kite aurorae decoration (620.16 KB, image/png)
2021-02-24 23:25 UTC, Paul McAuley
Details
A focused window with no close button displayed incorrectly in Kite aurorae decoration (727.96 KB, image/png)
2021-02-24 23:29 UTC, Paul McAuley
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul McAuley 2021-02-24 23:03:36 UTC
Created attachment 136130 [details]
A window with no maximize button displayed properly in Breeze binary decoration

Attached is a window without a maximize button (Strawberry album art) being displayed correctly in the binary Breeze theme.
Comment 1 Paul McAuley 2021-02-24 23:05:51 UTC
Created attachment 136131 [details]
A focused window with no maximize button displayed incorrectly in Kite aurorae decoration

Here is the same window displayed with the Kite Aurorae theme -- when the window is focused the maximize button is still displayed.
Comment 2 Paul McAuley 2021-02-24 23:07:42 UTC
Created attachment 136132 [details]
An unfocused window with no maximize button displayed incorrectly in Kite aurorae decoration

Here is the same window with the Kite Aurorae decoration when the window is unfocused. Notice the ugly big gap left by the disappearing maximize button.
Comment 3 Paul McAuley 2021-02-24 23:20:31 UTC
Created attachment 136134 [details]
Breeze binary decoration displaying window correctly without close button

... and it doesn't only happen for the maximize button. Here is a window displayed correctly without a close button.

...
Comment 4 Paul McAuley 2021-02-24 23:23:21 UTC
Created attachment 136135 [details]
A focused window with no close button displayed incorrectly in Kite aurorae decoration

... here is the same window intentionally with no close button (download new global themes) displayed incorrectly in the Kite Aurorae decoration. Confusingly you will try to click the close button and nothing will happen.
Comment 5 Paul McAuley 2021-02-24 23:25:50 UTC
Created attachment 136136 [details]
An unfocused window with no close button displayed incorrectly in Kite aurorae decoration

Here is what happens when the window intentionally without a close button is unfocused in Aurorae.
Comment 6 Paul McAuley 2021-02-24 23:29:45 UTC
Created attachment 136137 [details]
A focused window with no close button displayed incorrectly in Kite aurorae decoration

Attached the wrong image for a focused window with no close button displayed incorrectly in Kite aurorae decoration in comment 4. This is the correct version of what was attachment 136135 [details].
Comment 7 Paul McAuley 2021-02-24 23:41:07 UTC
I realised that this is because I did not specify a deactivated button design in my svgs for the "Kite" aurorae decoration (as described at https://techbase.kde.org/User:Mgraesslin/Aurorae). Aurorae decorations such as "Spectrum" specify such and display a greyed out button. However, I'd prefer a behaviour consistent with the Breeze binary behaviour where no button is displayed at all if the button is disabled.
Comment 8 Paul McAuley 2021-02-25 00:04:36 UTC
Preferred design:

If you specify a deactivated style in your svg, display it.
If you don't specify a deactivated style in your svg then do not display a button at all (and no gaps).

The current fallback behaviour when no deactivated style is specified in your svg is still not adequate because of the inconsistency between an active and inactive window, and is confusing because the user may try to click what looks like a button that should work.
Comment 9 Vlad Zahorodnii 2021-02-25 08:22:15 UTC
Yeah, it's a good idea not to display disabled buttons if the decoration theme doesn't provide a style for them.