Bug 433536 - 'Do not ask again' not working
Summary: 'Do not ask again' not working
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-24 14:48 UTC by francois5537
Modified: 2021-03-16 13:30 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Dialog (28.76 KB, image/png)
2021-02-24 14:48 UTC, francois5537
Details

Note You need to log in before you can comment on or make changes to this bug.
Description francois5537 2021-02-24 14:48:24 UTC
Created attachment 136113 [details]
Dialog

SUMMARY
I want to quit multiple applications using the new system monitor. This works fine, however it doesn't remember the option to not ask again. This seem to happen on other actions as well.

STEPS TO REPRODUCE
1. Select applications
2. Send KILL - 'Do not ask again' checked
3. Applications are killed

OBSERVED RESULT
Will ask again to remember decision

EXPECTED RESULT
Do not ask again again

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 5.21.1
(available in About System)
KDE Plasma Version: 5.21.1
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Patrick Silva 2021-03-05 13:32:02 UTC
On my system, "do not ask again" is remembered until System Monitor is restarted.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.21.80
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 2 Bug Janitor Service 2021-03-08 17:24:53 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/136
Comment 3 Arjen Hiemstra 2021-03-09 16:24:11 UTC
Git commit dc7a175d69fa8d05d58d94b0dc4298bc53165476 by Arjen Hiemstra.
Committed on 09/03/2021 at 11:40.
Pushed by ahiemstra into branch 'master'.

SensorFaceController: Save on destruction if the face requests it

This adds a property "ForceSaveOnDestroy" to the faceproperties file
that, if set, means SensorFaceController will save when destroyed, even
if "shouldSync" is set to false. This fixes issues where certain faces
would use face configuration for properties that change outside of an
"edit" mode.
Related: bug 433768, bug 434005

M  +2    -1    faces/SensorFaceController.cpp

https://invent.kde.org/plasma/libksysguard/commit/dc7a175d69fa8d05d58d94b0dc4298bc53165476
Comment 4 Arjen Hiemstra 2021-03-16 13:30:12 UTC
Git commit cf77c8ceddfdd098be46ee63c9be4405659f8e45 by Arjen Hiemstra.
Committed on 16/03/2021 at 13:29.
Pushed by ahiemstra into branch 'Plasma/5.21'.

SensorFaceController: Save on destruction if the face requests it

This adds a property "ForceSaveOnDestroy" to the faceproperties file
that, if set, means SensorFaceController will save when destroyed, even
if "shouldSync" is set to false. This fixes issues where certain faces
would use face configuration for properties that change outside of an
"edit" mode.
Related: bug 433768, bug 434005


(cherry picked from commit dc7a175d69fa8d05d58d94b0dc4298bc53165476)

M  +2    -1    faces/SensorFaceController.cpp

https://invent.kde.org/plasma/libksysguard/commit/cf77c8ceddfdd098be46ee63c9be4405659f8e45