Bug 433527 - Crash when clickung on wipe transition in timeline
Summary: Crash when clickung on wipe transition in timeline
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: git-master
Platform: Ubuntu Linux
: NOR crash
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-24 09:40 UTC by Martin Lang
Modified: 2021-03-04 12:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 21.04.0
fritzibaby: timeline_corruption+


Attachments
Screenshot from Crash stacktrace in gdb (291.53 KB, image/png)
2021-02-24 09:40 UTC, Martin Lang
Details
Screenshot of kdenlive before click on wipe transitions (15.12 KB, image/png)
2021-02-24 09:50 UTC, Martin Lang
Details
crash_log (4.17 KB, text/plain)
2021-03-01 18:25 UTC, emohr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Lang 2021-02-24 09:40:22 UTC
Created attachment 136106 [details]
Screenshot from Crash stacktrace in gdb

SUMMARY


STEPS TO REPRODUCE
1. Have to clips on the timeline grouped with a wipe transition between them. Both clips on the same track
2. Move the entire group to another track
3. Ungroup the clips
4. Move one clip to another track
5. Effect is: wipe transition remains at the original track
6. click on the wipe
7. Crash

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Martin Lang 2021-02-24 09:50:28 UTC
Created attachment 136107 [details]
Screenshot of kdenlive before click on wipe transitions
Comment 2 Martin Lang 2021-02-24 10:58:17 UTC
As can be seen from the gdb screenshot the AssetParameterModel& is a NULL Pointer reference
Comment 3 Martin Lang 2021-02-25 12:07:19 UTC
After some debugging I got the following insights: the list of effects is empty, which seems to be ok, because after dragging one clip the different timeline the wipe effect is removed.

The problem seems to be that the wipe is still visible and accessible.
Comment 4 emohr 2021-02-26 17:38:49 UTC
Please try with the current Kdenlive AppImage version 20.12.2 to see if there are any packaging issues https://download.kde.org/stable/kdenlive/20.12/linux/
Comment 5 Martin Lang 2021-02-27 09:05:24 UTC
Tried it. Exact same behavior. Tried 20.12.2 Ubutuntu Package, 20.12.2 AppImage and Downloaded gitmaster and compiled that version. All show same behavior.

Since I am new to Qt, if you have some hints into which classes I should have a deeper look with the debugger, I can do that.

I found already, that timelinemodel and trackmodel look at the first glance o.k. Their behavior seems to be consistent. Problem to me seems, that the wipe effect is still visible and "clickable" in the GUI, but not present in the corresponding model anymore.
Comment 6 emohr 2021-02-27 10:35:44 UTC
I tried your steps with same-track-transition. But with your step 5 the transition goes away. Please describe your first step a bit more in detail so I can try to reproduce the crash (a screenshot would help).
Comment 7 Martin Lang 2021-02-27 15:48:10 UTC
I tried several things and I think I found, what makes the difference:

New project, added 3 GoPro clips, each clip contains video and audio track.
Added two clips to timeline, switched picture preview in the Timeline-Menu off, and dragged end of first clip a little bit to the left and beginning of second clip a bit the right (yust to get some space for the in track transition)

Now 3 different sceanarios

Scenario 1)
- Added a transition by double clicking
- Moved first clip to a different track

Transition got removed, everthing fine

Scenario 2)
- As 1) but grouped both tracks 
- moved the group around
- ungrouped again
- moved first clip to different track

Transition got removed, everything fine

Note, both scenarios had video and audio track.

Scenario 3)
- Selected first clip
- ungrouped video and audio track
- deleted audio track from timelin
- ungrouped second clip and removed audio track
- added transition between the remaining video track
- moved first video clip to another track
- then you get the screenshot that is already attached
- clicking on the transition produces the crash

So the difference is the audio track

Made another check:
- Recreated the audio track again (from context menu option)
Everything works again
Comment 8 Julius Künzel 2021-03-01 16:11:44 UTC
Do you talk about real transitions between tracks ("Compositions") or about inline transitions ("Mix")?
Comment 9 emohr 2021-03-01 18:25:00 UTC
Created attachment 136295 [details]
crash_log

Confirmed. 
Crash happen with same track-transition. Keeping the thumbnail on: scenario 3, 6th step -> crash. Log see attached.
Comment 10 Julius Künzel 2021-03-02 16:57:06 UTC
Some hints:

A simpler way to reproduce is adding a color clip to an new project, add it twice to the timeline and add a "mix". It happens with audio too, the important thing is that it is single clip, not a group.

The crash only occurs if you drag the FIRST clip to a DIFFERENT TRACK. Moving it on the same track or or moving the second clip to another track works as expected.
Comment 11 Jean-Baptiste Mardelle 2021-03-04 08:00:25 UTC
Thanks for the details and reproducable steps. I am working on it.
Comment 12 Jean-Baptiste Mardelle 2021-03-04 08:48:44 UTC
Git commit 071d831f4f722f0051784841c7466967b308a8fb by Jean-Baptiste Mardelle.
Committed on 04/03/2021 at 08:48.
Pushed by mardelle into branch 'master'.

Fix incorrect handling of mix transition when moving one of the clips to another track

M  +2    -23   src/timeline2/model/timelinemodel.cpp

https://invent.kde.org/multimedia/kdenlive/commit/071d831f4f722f0051784841c7466967b308a8fb
Comment 13 Julius Künzel 2021-03-04 12:27:38 UTC
This is fixed with the commits above and will be in version 21.04.0 (Thanks Jean-Baptiste!)