Bug 433514 - Currency download from Yahoo uses "low" instead of "close" value
Summary: Currency download from Yahoo uses "low" instead of "close" value
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: 25.1.0
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-24 01:28 UTC by Christoph Vogtländer
Modified: 2021-03-18 21:55 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/office/skrooge/commit/4b1f206e597379e0d5e887ee05fd4370a643bdb1
Version Fixed In:
Sentry Crash Report:

Attachments
quick and dirty workaround (334 bytes, patch)
2021-02-24 01:28 UTC, Christoph Vogtländer 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Vogtländer 2021-02-24 01:28:05 UTC 
Created attachment 136100 [details]
quick and dirty workaround

SUMMARY
Version: 2.24.6
When downloading currency values using skrooge-yahoodl.py, Skrooge will use column "Low" instead of column "Close" (Skrooge does not seem to inspect the header but rather simply uses column "4" if I interpret the observed behavior correctly).

STEPS TO REPRODUCE
1. download currency EURUSD=X with Yahoo
2. get raw data with "/usr/share/skrooge/skrooge-yahoodl.py EURUSD=X 2021-02-18 2021-02-18 1d"

OBSERVED RESULT
value for 17.02.2021 in Skrooge is 1,20 (1.202559)

EXPECTED RESULT
value for 17.02.2021 should be 1,21 (1.209248)

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.21.0
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Kernel Version: 5.10.16-arch1-1
OS Type: 64-bit
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-4460 CPU @ 3.20GHz
Memory: 15.3 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4600

ADDITIONAL INFORMATION
When using stock values the effect is even more visible because stock values tend to vary a lot more over a day.
As a quick and dirty workaround I modified skrooge-yahoodl.py and switch column 5 and 4. See attached patch (don't know if this would be an acceptable solution, it is rather ugly).
Comment 1 Stephane MANKOWSKI 2021-03-18 21:55:40 UTC 
Git commit 4b1f206e597379e0d5e887ee05fd4370a643bdb1 by Stephane MANKOWSKI.
Committed on 18/03/2021 at 21:55.
Pushed by smankowski into branch 'master'.

Currency download from Yahoo uses "low" instead of "close"

M  +1    -0    CHANGELOG

https://invent.kde.org/office/skrooge/commit/4b1f206e597379e0d5e887ee05fd4370a643bdb1