Bug 433513 - Only one unnamed autosave works per session.
Summary: Only one unnamed autosave works per session.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Tiar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-23 23:23 UTC by Ralek Kolemios
Modified: 2021-03-18 15:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot of my directory (32.39 KB, image/png)
2021-03-16 17:24 UTC, Tiar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralek Kolemios 2021-02-23 23:23:32 UTC
d41048c

Just crashed after working a couple hours on an unsaved doodle (I know, my bad).
Had autosave on every minute since I like to bug report nightly builds, but when I crashed I noticed the only unnamed autosave file in my temp folder was from 4 hours ago, and was from a previous autosaved unnamed sketch that wasn't open anymore. For some reason, my second unnamed sketch didn't save anywhere. Is it possible to add the ability for more than one autosave to be saved?


Krita

 Version: 5.0.0-prealpha (git d41048c)
 Languages: en_US, en
 Hidpi: true

Qt

  Version (compiled): 5.12.9
  Version (loaded): 5.12.9

OS Information

  Build ABI: x86_64-little_endian-llp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: winnt
  Kernel Version: 10.0.19042
  Pretty Productname: Windows 10 (10.0)
  Product Type: windows
  Product Version: 10

OpenGL Info
 
  Vendor:  "Google Inc." 
  Renderer:  "ANGLE (NVIDIA GeForce RTX 2080 Ti Direct3D11 vs_5_0 ps_5_0)" 
  Version:  "OpenGL ES 3.0 (ANGLE 2.1.0.57ea533f79a7)" 
  Shading language:  "OpenGL ES GLSL ES 3.00 (ANGLE 2.1.0.57ea533f79a7)" 
  Requested format:  QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::CompatibilityProfile) 
  Current format:    QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples 0, swapBehavior QSurfaceFormat::DefaultSwapBehavior, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::NoProfile) 
     Version: 3.0
     Supports deprecated functions false 
     is OpenGL ES: true 

QPA OpenGL Detection Info 
  supportsDesktopGL: true 
  supportsAngleD3D11: true 
  isQtPreferAngle: true
Comment 1 Tiar 2021-02-25 12:21:39 UTC
In theory, they should be saved separately. Can you please attach Help -> Show Krita log for bug reports? It contains log for creating and saving images so it can give us a clue.
Comment 2 Bug Janitor Service 2021-03-12 04:33:40 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Tiar 2021-03-16 17:22:55 UTC
I cannot reproduce a file not being autosaved at all. I can only reproduce only one autosave per file, see: bug 434503
Comment 4 Tiar 2021-03-16 17:24:28 UTC
Created attachment 136744 [details]
Screenshot of my directory

All of those files should have a dark rectangle around them, but they don't. The autosave is just not triggered anymore.
Comment 5 Tiar 2021-03-18 15:04:44 UTC
Git commit f9a9ef808011ea4c1921bfe5b9275d41ab83d8a0 by Agata Cacko.
Committed on 18/03/2021 at 15:03.
Pushed by tymond into branch 'master'.

Fix autosave triggered only once per file

KisDocumentUndoStore's signal wasn't connected to the
KisImageSignalRouter, which caused the issue that
the autosave was only triggered once.
From the user point of view, it also resulted in the editing time
in File -> Document Information to be much lower than expected.
This commit connects the Document Undo Store to the SignalRouter
and ensures some more signals in KisDocumentUndoStore.
Those additional signals/emitions might not be needed.
Related: bug 434503

M  +4    -0    libs/image/kis_image.cc

https://invent.kde.org/graphics/krita/commit/f9a9ef808011ea4c1921bfe5b9275d41ab83d8a0