Bug 433508 - FreeBSD support, part 11
Summary: FreeBSD support, part 11
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other FreeBSD
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-23 20:41 UTC by Paul Floyd
Modified: 2021-10-09 12:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
coregrind added files (450.09 KB, patch)
2021-02-23 20:41 UTC, Paul Floyd 		Details
coregrind added files (450.91 KB, patch)
2021-09-23 19:49 UTC, Paul Floyd 		Details
coregrind added files (453.99 KB, patch)
2021-10-05 20:56 UTC, Paul Floyd 		Details
Show Obsolete (2) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Floyd 2021-02-23 20:41:10 UTC 
Created attachment 136095 [details]
coregrind added files

Patch for coregrind, only added files

All the usual platform paraphernalia
launcher
dispatch
initimg
sigframe
syswrap
Comment 1 Paul Floyd 2021-09-23 19:49:58 UTC 
Created attachment 141844 [details]
coregrind added files
Comment 2 Paul Floyd 2021-10-05 20:56:02 UTC 
Created attachment 142191 [details]
coregrind added files
Comment 3 Mark Wielaard 2021-10-08 00:15:24 UTC 
Make sure to add launcher-freebsd.c in coregrind/Makefile.am (valgrind_SOURCES) which was removed in commit f22758d6dad9bae9b7531046e42ce105f12e1ead

I didn't really review the 450K of new files. But they look plausible and are nicely separated from the other platform code (things build and work fine on my non-freebsd system). You might want to update the Copyright notices, while they are clearly derived from the other existing code, it would be good to mention the major copyright holders (I assume that is you and some of the people mentioned in the credits of README.freebsd).
Comment 4 Paul Floyd 2021-10-08 09:59:42 UTC 
> I didn't really review the 450K of new files. But they look plausible and
> are nicely separated from the other platform code (things build and work
> fine on my non-freebsd system). You might want to update the Copyright
> notices, while they are clearly derived from the other existing code, it
> would be good to mention the major copyright holders (I assume that is you
> and some of the people mentioned in the credits of README.freebsd).

As far as I know the main contributors were Doug Rabson (I just tried sending him an e-mail) and Stan Sedov (I have a copy of his hg repo which I'll use for dates).

And yes, most of these files were copied from the Linux versions.
Comment 5 Ed Maste 2021-10-08 17:29:34 UTC 
(In reply to Paul Floyd from comment #4)
> 
> As far as I know the main contributors were Doug Rabson (I just tried
> sending him an e-mail) and Stan Sedov (I have a copy of his hg repo which
> I'll use for dates).

I believe that's correct. The original port is mainly Doug Rabson's work,and Stanislav Sedov was a major contributor during his time as maintainer. Lots of contributions from others are as captured in README.freebsd.
Comment 6 Paul Floyd 2021-10-09 12:14:17 UTC 
Code committed with
commit e2e5d75f5cbc108d68142c4c56878df9abaed653