Bug 433504 - FreeBSD support, part 8
Summary: FreeBSD support, part 8
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other FreeBSD
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-23 19:51 UTC by Paul Floyd
Modified: 2021-10-07 20:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
patch of docs nightly and tests directories (12.33 KB, patch)
2021-02-23 19:51 UTC, Paul Floyd
Details
docs nightly and test scripts diff (13.04 KB, patch)
2021-09-23 19:32 UTC, Paul Floyd
Details
freebsd tests changes (8.22 KB, patch)
2021-09-26 21:25 UTC, Mark Wielaard
Details
freebsd docs changes (1.08 KB, text/plain)
2021-09-30 13:47 UTC, Mark Wielaard
Details
freebsd tests changes (9.42 KB, text/plain)
2021-09-30 14:11 UTC, Mark Wielaard
Details
docs diff (589 bytes, patch)
2021-10-05 20:52 UTC, Paul Floyd
Details
nightly directory (3.12 KB, patch)
2021-10-05 20:53 UTC, Paul Floyd
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Floyd 2021-02-23 19:51:26 UTC
Created attachment 136091 [details]
patch of docs nightly and tests directories

Diffs in docs and scripts

nightly script is currently adapted to my git repo and will need to revert back to sourceware. Also refers to me freebsd branch. Nightly conf files for FreeBSD 12.1, may need to add more recent versions.

Updates to arch and os tests

FreeBSD specific filtering
Comment 1 Paul Floyd 2021-09-23 19:32:18 UTC
Created attachment 141839 [details]
docs nightly and test scripts diff
Comment 2 Mark Wielaard 2021-09-26 21:25:04 UTC
Created attachment 141934 [details]
freebsd tests changes

The tests part needs to be applied before other tools tests are added. The attached (only the tests, ignoring docs and nightly changes) goes after the freebsd3.patch
Comment 3 Paul Floyd 2021-09-27 16:29:57 UTC
I'll cleanup the nightly script tonight to make it no longer specific to my personal setup.
Comment 4 Mark Wielaard 2021-09-30 13:38:01 UTC
I would recommend doing the docs part separately from nightly, just like the tests part. Note that the original patch changes docs/xml/dist-docs.xml to be executable, which I believe to be wrong.
Comment 5 Mark Wielaard 2021-09-30 13:47:43 UTC
Created attachment 142033 [details]
freebsd docs changes

The separated out docs patch is fairly simple and works fine as is (on fedora 34 x86_64).
Comment 6 Mark Wielaard 2021-09-30 14:11:32 UTC
Created attachment 142034 [details]
freebsd tests changes

I messed up the freebsd-tests.patch for the filters. This adds filter_discards.in and renames tests/filter_stderr_basic.in properly.

All freebsd patches as I have been testing them on Fedora 34 x86_64 can also be found here: https://code.wildebeest.org/git/user/mjw/valgrind/log/?h=freebsd (warning, I am still adding patches and might rebase things a bit)
Comment 7 Paul Floyd 2021-10-05 20:52:43 UTC
Created attachment 142187 [details]
docs diff

patch just for docs
Comment 8 Paul Floyd 2021-10-05 20:53:23 UTC
Created attachment 142188 [details]
nightly directory
Comment 9 Paul Floyd 2021-10-07 20:22:32 UTC
Code committed with
commit 3d25fd4a6c188f6183e69693920f81e3bc4e474f (nightly)
commit a6096335c3f0d01c57b87538430de805aa632260 (docs)
commit b128b20e66adbf00e87cf43e00e07ffe04f2ba8b (tests)