Created attachment 136080 [details] Helgrind tests patch Helgrind tests changes Makefile.am - new expecteds and filters bar_bad - bogus pthread barrier was causing a crash, so made that conditional, also requires a new expected tc09 - as above but with a mutex tc23 - as above but with condition signal filter_freebsd - adds "@*" to thread function names, reduces requirements for more expecteds filter_stderr_freebsd - as above filter_stderr - more filters, needs work ro make sed a configure variable tc07 and tc08 and tc11 - add FreeBSD platform macros
Created attachment 141838 [details] diff in helgrind/tests
As far as I can see this looks good (I cannot really comment on th freebsd specific filters and exp files). But the modifications to the tests look OK. This is missing the .gitignore and CONFIG configure.ac entries for helgrind/tests/filter_stderr With that it builds and all tests under helgrind/tests PASS for me on fedora 34 x86_64. It also makes all tests under drd/tests PASS. I recommend merging this patch with the freebsd5.patch for the drd tests, since they share some source files.
Created attachment 142030 [details] freebsd7 This is the patch as I tested it (only changes are the additions to .gitignore and configure.ac)
Created attachment 142031 [details] freebsd7 Sorry, that patch didn't include helgrind/tests/filter_stderr.in This one does.
I've merged this with patch 5 (drd tests) in my working repo. Aiming to finish all by tonight (2021-20-05).
Created attachment 142186 [details] test directory Hijacking this from hg tests to be just the test directory
Code committed as commit b128b20e66adbf00e87cf43e00e07ffe04f2ba8b