Bug 433417 - krunner lost close button and uses wrong colors in tooltip
Summary: krunner lost close button and uses wrong colors in tooltip
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: 5.21.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Lohnau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-22 07:32 UTC by Martin Koller
Modified: 2021-07-01 12:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (62.31 KB, image/png)
2021-02-22 10:30 UTC, Martin Koller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Koller 2021-02-22 07:32:42 UTC
SUMMARY
since the last update, krunner lost its close button on the right top side.

Also, the "Configure" and "Keep Open" buttons use grey background color for the tooltips, but I have configured to use some blue as tooltip background, which is shown correctly on an action krunner finds (e.g. type "1+1" (calculation) and hover above the right "copy" action)

EXPECTED RESULT
use globally defined colors

Operating System: openSUSE Tumbleweed 20210219
KDE Plasma Version: 5.21.0
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Kernel Version: 5.10.16-1-default
OS Type: 64-bit
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-6300U CPU @ 2.40GHz
Memory: 15,5 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 520
Comment 1 Alexander Lohnau 2021-02-22 10:18:54 UTC
>since the last update, krunner lost its close button on the right top side.

Yeah that is intentional, it has been refactored to the pin button.

>EXPECTED RESULT
>use globally defined colors

And can you please provide a screenshot?

And please check if it can be reproduced when you run `kquitapp5 krunner;krunner&` in the terminal.
Comment 2 Martin Koller 2021-02-22 10:30:08 UTC
>>since the last update, krunner lost its close button on the right top side.

>Yeah that is intentional, it has been refactored to the pin button.

A pin button and a close button are completely different things.
Why should a pin button be a better option than a close button ?
I'm missing the close button and don't need a pin button.

Regarding the tooltip, I'm attaching a screenshot.
After restart of krunner it got worse and now cuts the tooltip at the krunner window borders. I have added this in the screenshot as well.
Comment 3 Martin Koller 2021-02-22 10:30:52 UTC
Created attachment 136039 [details]
screenshot
Comment 4 Kai Uwe Broulik 2021-02-22 11:01:27 UTC
What's your use case for a dedicated close button? KRunner closes when it loses focus anyway, so we decided to turn it into a Pin button so you can keep it open explicitly if you so desire.
Comment 5 Martin Koller 2021-02-22 11:20:36 UTC
The additional pin button is ok for whoever wants it.
But the close button was there for a reason and I used it, so now I'm missing it.
The use case is simply to close the window.
Since one can interact with the window (typing something) it's common to also have an action button to dismiss a "dialog".
krunner is not a popup window like a tooltip. It's an interactive thingy.
Comment 6 Martin Koller 2021-03-05 11:31:17 UTC
Another issue I now often hit with the missing close button:
I watch a youtube video in fullscreen. I see some US degrees in F and want to know what this is in C.
So I hit Alt-F2 to get krunner, enter e.g. 45F and see immediately the C value.
Now: how to close krunner ?
When I hit escape, it will act on the browser player and cancel the fullscreen mode.
If I click outside of krunner also the player will react and pause.

Please bring back the close button.
Comment 7 Alexander Lohnau 2021-04-07 09:20:45 UTC
But in this case you could press Alt+Space again to toggle the visibility and consequently hide KRunner without having to press escape
Comment 8 Martin Koller 2021-04-07 09:35:19 UTC
And you see why this is not user friendly: I never thought of that option.
Yes, it works (just checked) but far from obvious.
Comment 9 Alexander Lohnau 2021-07-01 11:51:54 UTC
>Yes, it works (just checked) but far from obvious.

This is also the same behavior as the application launcher, yakuake and others. I would say it was unintuitive because it did not work before ;)
Comment 10 Martin Koller 2021-07-01 12:58:27 UTC
No it was not unintuitive because it did not work.
It still is unintuitive because: it's not intuitive