Bug 433394 - Encoded forward slash causes Discogs API import to fail
Summary: Encoded forward slash causes Discogs API import to fail
Status: RESOLVED FIXED
Alias: None
Product: kid3
Classification: Applications
Component: general (show other bugs)
Version: 3.8.x
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Urs Fleisch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-21 16:47 UTC by jesse
Modified: 2021-03-18 05:24 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Unsuccessful Discogs API request showing what looks like a bad path (187.17 KB, image/png)
2021-02-21 16:47 UTC, jesse
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jesse 2021-02-21 16:47:59 UTC
Created attachment 136016 [details]
Unsuccessful Discogs API request showing what looks like a bad path

SUMMARY

Encoded forward slash causes Discogs API import to fail

STEPS TO REPRODUCE
1. Open any folder in Kid3
2. Attempt to perform Import from Discogs
3. 

OBSERVED RESULT

Server gives Not Found error on all requests. From the attached jpg, it looks like an undecoded %2F (forward slash) is causing an error with the path.


EXPECTED RESULT

Retrieve track metadata successfully.


SOFTWARE/OS VERSIONS

macOS: 10.14.3


ADDITIONAL INFORMATION

See attached image.
And thanks for developing this software. I find it really useful!
Comment 1 Urs Fleisch 2021-02-23 20:33:25 UTC
Apparently the Discogs import is one of the most important features, I got multiple nearly identical issues here on Bugzilla, and also some emails. I will leave this issue open so that it is easier to find for other people. The problem with the Discogs import is that it is parsing the HTML output from the Discogs server, and the people at Discogs often change it, which then breaks the import.

Since Kid3 3.8.5, there is also the possibility to import using the Discogs JSON API. However, you need to register for an API token at Discogs. You have to register for an account on https://www.discogs.com/ and then generate a token on their web site (Settings/Developers, Generate new token). The token can be entered in the Discogs import dialog. Don't forget to save the settings after entering the token in order to use it in subsequent requests too.

If you do not want to register for a token, you can wait until March 18, I will then publish a new version 3.8.6 with a fixed Discogs import. Already today, you can use one of the development binary packages which are available at https://sourceforge.net/projects/kid3/files/kid3/development/, they have the Discogs import fixed.
Comment 2 jesse 2021-02-23 22:05:31 UTC
Thanks for the quick response—I didn't see another report of this, so hopefully this wasn't duplicating an existing one.

It does work with the token though! Good workaround. Thanks for the info, and for this app that has really come in handy for me.
Comment 3 Urs Fleisch 2021-03-18 05:24:05 UTC
Fixed in version 3.8.6.