Bug 433324 - Filter text in 'applications' tab is not cleared properly when switching tabs
Summary: Filter text in 'applications' tab is not cleared properly when switching tabs
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Other
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-20 12:29 UTC by Kishore Gopalakrishnan
Modified: 2021-03-10 16:02 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21.3


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2021-02-20 12:29:29 UTC
SUMMARY
When you filter the list of applications, switch tabs, and then return to the applications list, the filter is left in a confusing state (no filter text shown, but the filtering is still applied).

STEPS TO REPRODUCE
1. Go to 'applications' tab.
2. Type something in the 'search' box at the top.
3. Press 'enter'
4. Go to another tab
5. Go back to the 'applications' tab

OBSERVED BEHAVIOUR
Applications are still filtered according to the typed text, but the search box is empty. There is no obvious way to show an unfiltered list of applications again, other than performing a search for an empty string.

EXPECTED BEHAVIOUR
Either
1. It should forget the filter text and properly show the full unfiltered list when you change tabs
2. If filter status is remembered, the filter text should be shown in the textbox.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.21.0
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Comment 1 Arjen Hiemstra 2021-03-10 12:48:37 UTC
Git commit 95b05cc1eaa2c8766b0b1f0478d6583d8bb308d8 by Arjen Hiemstra.
Committed on 10/03/2021 at 12:48.
Pushed by ahiemstra into branch 'master'.

Display existing search text in search field for application/process pages

If the actions of the current page include the table actions, they will
be recreated when switching pages. However, the actual search string
will persist and still filter the table. So ensure we display the
existing filter string when we switch back to avoid confusion of why not
everything is shown.

M  +1    -0    src/faces/applicationstable/contents/ui/FullRepresentation.qml
M  +1    -0    src/faces/processtable/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/95b05cc1eaa2c8766b0b1f0478d6583d8bb308d8
Comment 2 Arjen Hiemstra 2021-03-10 12:51:34 UTC
Git commit ef09d30da772be5e410b5f50767033ff19c43bfe by Arjen Hiemstra.
Committed on 10/03/2021 at 12:51.
Pushed by ahiemstra into branch 'Plasma/5.21'.

Display existing search text in search field for application/process pages

If the actions of the current page include the table actions, they will
be recreated when switching pages. However, the actual search string
will persist and still filter the table. So ensure we display the
existing filter string when we switch back to avoid confusion of why not
everything is shown.


(cherry picked from commit 95b05cc1eaa2c8766b0b1f0478d6583d8bb308d8)

M  +1    -0    src/faces/applicationstable/contents/ui/FullRepresentation.qml
M  +1    -0    src/faces/processtable/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/ef09d30da772be5e410b5f50767033ff19c43bfe