Bug 433118 - make tools area separator line optional
Summary: make tools area separator line optional
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (show other bugs)
Version: 5.21.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 433371 433748 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-17 21:36 UTC by Milian Wolff
Modified: 2021-10-21 15:03 UTC (History)
11 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/breeze/commit/3685a1673e117e8c3b3c0539f6271ede3dfe00c2
Version Fixed In: 5.21.1
Sentry Crash Report:

Attachments
disabled drawing the border (37.60 KB, image/png)
2021-02-17 21:36 UTC, Milian Wolff 		Details
double frame (37.60 KB, image/png)
2021-02-17 21:37 UTC, Milian Wolff 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Milian Wolff 2021-02-17 21:36:39 UTC 
Created attachment 135794 [details]
disabled drawing the border

SUMMARY

the recent change to add the visual separator line between the toolbar/menu area and the center widget adds a lot of visual clutter. Compare the attached before/after screenshots to see what I mean. Esp. note the run-in of the separator line with widget frames from the central widget in kdevelop, kwrite and other applications

STEPS TO REPRODUCE
1. use breeze-dark color theme and breeze widget theme
2. start kwrite
3. look at the top of the window

OBSERVED RESULT
you'll see a see a double-frame

EXPECTED RESULT
no double-frame


SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Comment 1 Milian Wolff 2021-02-17 21:37:30 UTC 
Created attachment 135795 [details]
double frame
Comment 2 David Redondo 2021-02-17 21:53:10 UTC 
I had a patch to not draw the line at least for color schemes that have no headers color group and we draw no tools area because of that. Would have applied to normal breeze but that was reverted...

https://invent.kde.org/plasma/breeze/-/merge_requests/49
Comment 3 Ian Schwarz 2021-02-19 08:54:27 UTC 
Relevant MR in KDE Gitlab: https://invent.kde.org/plasma/breeze/-/merge_requests/83
Comment 4 Nate Graham 2021-02-21 22:29:01 UTC 
Git commit 2f1fc86a131361e367311d0560485d94f9c59039 by Nate Graham.
Committed on 17/02/2021 at 21:38.
Pushed by ngraham into branch 'master'.

Revert "Revert "Do not draw background or line in toolbars if the color scheme has no headers group""

This reverts commit 9f40b17e573dee1fa7779464181a24cb875c3825.

The idea of a Tools Area separator only makes sense when there is a unibody
Tools Area. When using a color scheme without Header colors, there is no
Tools Area (just a disparate collection of titlebars, manubars, and
toolbars), so the line is just extra visual noise that various people
have objected to following the Plasma 5.21 release. Let's make it
conditional on using a color scheme with Header colors again.
FIXED-IN: 5.21.1

M  +1    -1    kstyle/breezestyle.cpp
M  +7    -0    kstyle/breezetoolsareamanager.cpp
M  +3    -0    kstyle/breezetoolsareamanager.h

https://invent.kde.org/plasma/breeze/commit/2f1fc86a131361e367311d0560485d94f9c59039
Comment 5 Nate Graham 2021-02-21 22:29:40 UTC 
Git commit 3685a1673e117e8c3b3c0539f6271ede3dfe00c2 by Nate Graham.
Committed on 21/02/2021 at 22:29.
Pushed by ngraham into branch 'Plasma/5.21'.

Revert "Revert "Do not draw background or line in toolbars if the color scheme has no headers group""

This reverts commit 9f40b17e573dee1fa7779464181a24cb875c3825.

The idea of a Tools Area separator only makes sense when there is a unibody
Tools Area. When using a color scheme without Header colors, there is no
Tools Area (just a disparate collection of titlebars, manubars, and
toolbars), so the line is just extra visual noise that various people
have objected to following the Plasma 5.21 release. Let's make it
conditional on using a color scheme with Header colors again.
FIXED-IN: 5.21.1


(cherry picked from commit 2f1fc86a131361e367311d0560485d94f9c59039)

M  +1    -1    kstyle/breezestyle.cpp
M  +7    -0    kstyle/breezetoolsareamanager.cpp
M  +3    -0    kstyle/breezetoolsareamanager.h

https://invent.kde.org/plasma/breeze/commit/3685a1673e117e8c3b3c0539f6271ede3dfe00c2
Comment 6 Nate Graham 2021-02-23 03:31:39 UTC 
*** Bug 433371 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2021-02-28 21:27:53 UTC 
*** Bug 433748 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2021-10-21 15:03:15 UTC 
*** Bug 444139 has been marked as a duplicate of this bug. ***