Bug 433109 - desktop-file-validate fails on systemsettings.desktop
Summary: desktop-file-validate fails on systemsettings.desktop
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.21.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-17 19:43 UTC by rezso
Modified: 2021-03-02 13:58 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rezso 2021-02-17 19:43:08 UTC
/usr/share/applications/systemsettings.desktop: error: value "kcm_lookandfeel;kcm_users;screenlocker;powerdevilprofilesconfig;kcm_kscreen;" for key "Actions" in group "Desktop Entry" contains invalid action identifier "kcm_lookandfeel", only alphanumeric characters and '-' are allowed
/usr/share/applications/systemsettings.desktop: error: file contains group "Desktop Action kcm_lookandfeel", which has an invalid action identifier, only alphanumeric characters and '-' are allowed
/usr/share/applications/systemsettings.desktop: error: file contains group "Desktop Action kcm_users", which has an invalid action identifier, only alphanumeric characters and '-' are allowed
/usr/share/applications/systemsettings.desktop: error: file contains group "Desktop Action kcm_kscreen", which has an invalid action identifier, only alphanumeric characters and '-' are allowed
/usr/share/applications/systemsettings.desktop: error: action group "Desktop Action powerdevilprofilesconfig" exists, but there is no matching action "powerdevilprofilesconfig"
/usr/share/applications/systemsettings.desktop: error: action group "Desktop Action screenlocker" exists, but there is no matching action "screenlocker"
Error: /usr/share/applications/systemsettings.desktop: hibás desktop fájl!

As a workaround, I reverted https://github.com/KDE/systemsettings/commit/4e59619ba862378b19edf674df3cfa75ee76724b for my build.
Comment 1 Nate Graham 2021-02-17 23:19:38 UTC
Ugh this sucks. "_" has to be used since it's present in the name of the KCMs!
Comment 2 David Redondo 2021-02-18 09:27:21 UTC
This is about the name of the groups, where we could just drop the kcm_ prefix
Comment 3 David Geiger 2021-02-28 15:44:56 UTC
Hi,

We have the same issue on Mageia Cauldron during build:

+ /usr/share/spec-helper/check_desktop_files
/home/iurt/rpmbuild/BUILDROOT/systemsettings-5.21.1-1.mga9.x86_64/usr/share/applications/systemsettings.desktop: error: value "kcm_lookandfeel;kcm_users;screenlocker;powerdevilprofilesconfig;kcm_kscreen;" for key "Actions" in group "Desktop Entry" contains invalid action identifier "kcm_lookandfeel", only alphanumeric characters and '-' are allowed
/home/iurt/rpmbuild/BUILDROOT/systemsettings-5.21.1-1.mga9.x86_64/usr/share/applications/systemsettings.desktop: error: file contains group "Desktop Action kcm_lookandfeel", which has an invalid action identifier, only alphanumeric characters and '-' are allowed
/home/iurt/rpmbuild/BUILDROOT/systemsettings-5.21.1-1.mga9.x86_64/usr/share/applications/systemsettings.desktop: error: file contains group "Desktop Action kcm_users", which has an invalid action identifier, only alphanumeric characters and '-' are allowed
/home/iurt/rpmbuild/BUILDROOT/systemsettings-5.21.1-1.mga9.x86_64/usr/share/applications/systemsettings.desktop: error: file contains group "Desktop Action kcm_kscreen", which has an invalid action identifier, only alphanumeric characters and '-' are allowed
/home/iurt/rpmbuild/BUILDROOT/systemsettings-5.21.1-1.mga9.x86_64/usr/share/applications/systemsettings.desktop: error: action group "Desktop Action powerdevilprofilesconfig" exists, but there is no matching action "powerdevilprofilesconfig"
/home/iurt/rpmbuild/BUILDROOT/systemsettings-5.21.1-1.mga9.x86_64/usr/share/applications/systemsettings.desktop: error: action group "Desktop Action screenlocker" exists, but there is no matching action "screenlocker"
Validating </home/iurt/rpmbuild/BUILDROOT/systemsettings-5.21.1-1.mga9.x86_64/usr/share/applications/systemsettings.desktop> failed! at /usr/share/spec-helper/check_desktop_files line 34.
error: Bad exit status from /home/iurt/rpmbuild/tmp/rpm-tmp.RhtJwa (%install)


Also to validate a package we launch the check desktop file script automatically in our build system so we can't build this package for now, except  reverted the commit.

What can be done to fix this rpmlint error?
Comment 4 Bug Janitor Service 2021-03-02 11:06:11 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/53
Comment 5 David Redondo 2021-03-02 13:58:10 UTC
Git commit 01a13355cadbd3b6fb50292a9ac63b1bb1e418ac by David Redondo.
Committed on 02/03/2021 at 13:55.
Pushed by davidre into branch 'master'.

Underscores are not allowed in action names

M  +4    -4    app/systemsettings.desktop

https://invent.kde.org/plasma/systemsettings/commit/01a13355cadbd3b6fb50292a9ac63b1bb1e418ac
Comment 6 David Redondo 2021-03-02 13:58:48 UTC
Git commit a0b4a391bb8f0447c357922afe69241bd47fc41e by David Redondo.
Committed on 02/03/2021 at 13:58.
Pushed by davidre into branch 'Plasma/5.21'.

Underscores are not allowed in action names


(cherry picked from commit 01a13355cadbd3b6fb50292a9ac63b1bb1e418ac)

M  +4    -4    app/systemsettings.desktop

https://invent.kde.org/plasma/systemsettings/commit/a0b4a391bb8f0447c357922afe69241bd47fc41e