Bug 433078 - Reviews are truncated and can be only viewed in full with the "Show all x reviews..." button
Summary: Reviews are truncated and can be only viewed in full with the "Show all x rev...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.20.5
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-02-17 14:50 UTC by Paul McAuley
Modified: 2021-02-17 19:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul McAuley 2021-02-17 14:50:00 UTC
Reviews are truncated when viewed. To see the full reviews you have to click the "Show all x reviews..." button. However, this button is not visible when there are few reviews!
Comment 1 Nate Graham 2021-02-17 19:39:26 UTC
Oof! We should probably not truncate the reviews shown on the main app page at all.
Comment 2 Nate Graham 2021-02-17 19:45:23 UTC
Git commit 37dea710a721d28afe5db4d493f160e3941750ee by Nate Graham.
Committed on 17/02/2021 at 19:43.
Pushed by ngraham into branch 'master'.

Don't truncate reviews in compact mode

Otherwise 1) they can get cut off awkwardly and be useless
          2) if there are 3 or fewer reviews, there's no way
             to get to the full version on the reviews sheet
FIXED-IN: 5.21.1

M  +0    -1    discover/qml/ReviewDelegate.qml

https://invent.kde.org/plasma/discover/commit/37dea710a721d28afe5db4d493f160e3941750ee
Comment 3 Nate Graham 2021-02-17 19:46:04 UTC
Git commit b4d039ebfc29488cd05c301999f9ddaca9640c5b by Nate Graham.
Committed on 17/02/2021 at 19:45.
Pushed by ngraham into branch 'Plasma/5.21'.

Don't truncate reviews in compact mode

Otherwise 1) they can get cut off awkwardly and be useless
          2) if there are 3 or fewer reviews, there's no way
             to get to the full version on the reviews sheet
FIXED-IN: 5.21.1
(cherry picked from commit 37dea710a721d28afe5db4d493f160e3941750ee)

M  +0    -1    discover/qml/ReviewDelegate.qml

https://invent.kde.org/plasma/discover/commit/b4d039ebfc29488cd05c301999f9ddaca9640c5b