Bug 433037 - Avatar does not preserve transparency in source image
Summary: Avatar does not preserve transparency in source image
Status: CONFIRMED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-16 23:20 UTC by twinshadows404
Modified: 2021-02-23 16:51 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
example (2.79 KB, image/png)
2021-02-16 23:20 UTC, twinshadows404 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description twinshadows404 2021-02-16 23:20:11 UTC 
Created attachment 135747 [details]
example

It looks off when a white theme is used.
Comment 1 David Edmundson 2021-02-16 23:29:44 UTC 
That's quite cropped. What is that a screenshot of?
Comment 2 twinshadows404 2021-02-17 00:46:50 UTC 
The new plasma menu, the circle around the avatar is white while the menu is black.
Comment 3 Mikel Johnson 2021-02-17 16:05:38 UTC 
not sure what you want here
Comment 4 twinshadows404 2021-02-17 16:18:33 UTC 
Make it transparent like on the lock screen/ 
Keep the transparency from the icon
Comment 5 Mikel Johnson 2021-02-17 16:40:51 UTC 
that's a framework thing then (Kirigami's Avatar)

also looks are most likely intentional but I digress
Comment 6 Marco Martin 2021-02-23 11:13:19 UTC 
Yes, it's intentional.
API-wise is possible to have it, with

Avatar {
    background.color: "transparent"
}
Comment 7 Nate Graham 2021-02-23 15:17:07 UTC 
Thanks. Moving back to Kickoff.
Comment 8 Nate Graham 2021-02-23 15:23:50 UTC 
background.color: is not a valid public property. color: is a public property, but overriding that to be transparent impacts the appearance of the auto-generated image, which is not desired.

I cannot find a way to use the existing API to preserve transparency for non-auto-generated backgrounds. without impacting the auto-generated ones.

Moving back to Kirigami.
Comment 9 Mikel Johnson 2021-02-23 15:55:12 UTC 
I think we'd wanna change the default to maintain consistency
Comment 10 Nate Graham 2021-02-23 16:51:23 UTC 
Oops, forgot to move it. Thanks for doing so.