Bug 433029 - Arithmetic The magician hat (composition) identical levels 1 and 2
Summary: Arithmetic The magician hat (composition) identical levels 1 and 2
Status: RESOLVED FIXED
Alias: None
Product: gcompris
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Jazeix Johnny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-16 20:40 UTC by Rolas
Modified: 2021-03-10 05:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Arithmetic The magician hat (composition) (23.77 KB, image/jpeg)
2021-02-16 20:40 UTC, Rolas
Details
Before click on the hat i see ready task? (14.08 KB, image/jpeg)
2021-02-17 06:15 UTC, Rolas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rolas 2021-02-16 20:40:40 UTC
Created attachment 135737 [details]
Arithmetic The magician hat (composition)

Arithmetic 
The magician hat (composition)

levels 1 and 2 
(Add stars up to 5. and  Add stars up to 10)
are identical - "up to 10"
Level 1 now can add more than 5 stars
Comment 1 Jazeix Johnny 2021-02-16 21:58:32 UTC
Hi,
I can reproduce it.

Thank you for the report, we'll do our best to fix it for the release in March
Comment 3 Jazeix Johnny 2021-02-16 22:22:09 UTC
Fixed in https://invent.kde.org/education/gcompris/commit/5590be8ae9d7e9e23baaf39eb8dd1a1d6c105be1

Thank you again!
Comment 4 Rolas 2021-02-17 06:15:11 UTC
Created attachment 135749 [details]
Before click on the hat i see ready task?

p.s.
if you change the number of stars in the sequence from 10 to 5, you need to change also in (magic-hat-minus)

before clicking on the hat, magic-hat-minus sees one filled line with asterisks, the second line is filled by clicking on the hat

magic-hat-plus before clicking on the hat we see a ready task with all the stars
so it must be?
Comment 5 Jazeix Johnny 2021-03-09 19:47:42 UTC
(In reply to Rolas from comment #4)
> Created attachment 135749 [details]
> Before click on the hat i see ready task?
> 
> p.s.
> if you change the number of stars in the sequence from 10 to 5, you need to
> change also in (magic-hat-minus)
> 

I couldn't reproduce this one, I always had 5 stars max in minus mode.

> before clicking on the hat, magic-hat-minus sees one filled line with
> asterisks, the second line is filled by clicking on the hat
> 
> magic-hat-plus before clicking on the hat we see a ready task with all the
> stars
> so it must be?

The animations are different because in the case of the subtraction, we show the fact that we restore some stars and we need to count how many are still under the hat.
For the addition, we already have the lines, we add them and the child needs to count how many stars are in the hat again. That's why the stars are already placed, it would not make sense to remove them from under the hat.

I'm not sure I've fully understood the question, so if I'm not answering to the good question, please ask again :)
Comment 6 Rolas 2021-03-10 05:51:26 UTC
(In reply to Jazeix Johnny from comment #5)
> (In reply to Rolas from comment #4)
> > Created attachment 135749 [details]
> > Before click on the hat i see ready task?
> > 
> > p.s.
> > if you change the number of stars in the sequence from 10 to 5, you need to
> > change also in (magic-hat-minus)
> > 
> 
> I couldn't reproduce this one, I always had 5 stars max in minus mode.

now i get it right too. maybe earlier I set the levels incorrectly. Sorry

> 
> > before clicking on the hat, magic-hat-minus sees one filled line with
> > asterisks, the second line is filled by clicking on the hat
> > 
> > magic-hat-plus before clicking on the hat we see a ready task with all the
> > stars
> > so it must be?
> 
> The animations are different because in the case of the subtraction, we show
> the fact that we restore some stars and we need to count how many are still
> under the hat.
> For the addition, we already have the lines, we add them and the child needs
> to count how many stars are in the hat again. That's why the stars are
> already placed, it would not make sense to remove them from under the hat.
> 
> I'm not sure I've fully understood the question, so if I'm not answering to
> the good question, please ask again :)

thank you,you are right
now we understand the logic of subtraction with a hat
this question of mine was redundant