Bug 432807 - Review sheet is almost unusably narrow and can't be made wider
Summary: Review sheet is almost unusably narrow and can't be made wider
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.20.90
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
: 433046 433413 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-11 15:57 UTC by Nate Graham
Modified: 2021-02-22 20:13 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21.1


Attachments
Unusably narrow (388.25 KB, image/jpeg)
2021-02-11 15:57 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-02-11 15:57:18 UTC
Created attachment 135598 [details]
Unusably narrow

Everything KDE from git master. See attached screenshot.

Not sure if this is caused by changes in Discover, or changes in Kirigami to expose a pre-existing bug.
Comment 1 Nate Graham 2021-02-11 16:02:32 UTC
Git commit 03f41d384a6c8e7475a8ab948142015a21a75d2c by Nate Graham.
Committed on 11/02/2021 at 15:57.
Pushed by ngraham into branch 'master'.

Increase maximum width of review dialog to a sane size

A maximum value was set over a year ago but seems to have been somehow
ignored until recent changes in Kirigami made it take effect--at which
point it was revealed to be an absurdly low maximum value (144px wide
with the standard 10pt Noto Sans font). The principle of a maximum width
makes sense to prevent the dialog from looking silly with very wide
windows, but the current maximum is much too small. Let's triple it.
FIXED-in: 5.20.1

M  +1    -1    discover/qml/ReviewDialog.qml

https://invent.kde.org/plasma/discover/commit/03f41d384a6c8e7475a8ab948142015a21a75d2c
Comment 2 Nate Graham 2021-02-11 16:03:02 UTC
Git commit 4e79743b6fc982d9472653e0123e2e2902d983dc by Nate Graham.
Committed on 11/02/2021 at 16:02.
Pushed by ngraham into branch 'Plasma/5.21'.

Increase maximum width of review dialog to a sane size

A maximum value was set over a year ago but seems to have been somehow
ignored until recent changes in Kirigami made it take effect--at which
point it was revealed to be an absurdly low maximum value (144px wide
with the standard 10pt Noto Sans font). The principle of a maximum width
makes sense to prevent the dialog from looking silly with very wide
windows, but the current maximum is much too small. Let's triple it.
FIXED-in: 5.20.1
(cherry picked from commit 03f41d384a6c8e7475a8ab948142015a21a75d2c)

M  +1    -1    discover/qml/ReviewDialog.qml

https://invent.kde.org/plasma/discover/commit/4e79743b6fc982d9472653e0123e2e2902d983dc
Comment 3 Nate Graham 2021-02-17 23:00:02 UTC
*** Bug 433046 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2021-02-22 20:13:13 UTC
*** Bug 433413 has been marked as a duplicate of this bug. ***