Bug 432693 - Disabled "Search" action on Featured page
Summary: Disabled "Search" action on Featured page
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.20.90
Platform: Other Linux
: HI normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-02-09 16:11 UTC by Nate Graham
Modified: 2021-02-10 03:04 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/discover/commit/76b2f0604f40762d36dbcafb85bf1e80c6961cb5
Version Fixed In:
Sentry Crash Report:

Attachments
Disabled search action on featured page (25.89 KB, image/jpeg)
2021-02-09 16:11 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-02-09 16:11:37 UTC 
Created attachment 135534 [details]
Disabled search action on featured page

git bisect says it's was a regression from:

commit b0c52067283502d398fa0ffb974696322bf96af0 (HEAD, refs/bisect/good-b0c52067283502d398fa0ffb974696322bf96af0)
Author: Aleix Pol <aleixpol@kde.org>
Date:   Thu Feb 4 03:05:29 2021 +0100

    Show a "Search" main action on mobile on the Featured page
Comment 1 Bug Janitor Service 2021-02-10 01:16:14 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/76
Comment 2 Aleix Pol 2021-02-10 03:04:32 UTC 
Git commit 3fb0d529ca9544c312f426ca024dfcd053937611 by Aleix Pol.
Committed on 10/02/2021 at 01:11.
Pushed by apol into branch 'master'.

Don't show the search action on desktop mode

It's disabled anyway, it's just noise.

M  +1    -0    discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/commit/3fb0d529ca9544c312f426ca024dfcd053937611
Comment 3 Aleix Pol 2021-02-10 03:04:54 UTC 
Git commit 76b2f0604f40762d36dbcafb85bf1e80c6961cb5 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 10/02/2021 at 03:04.
Pushed by apol into branch 'Plasma/5.21'.

Don't show the search action on desktop mode

It's disabled anyway, it's just noise.


(cherry picked from commit 3fb0d529ca9544c312f426ca024dfcd053937611)

M  +1    -0    discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/commit/76b2f0604f40762d36dbcafb85bf1e80c6961cb5