Bug 432613 - Face detection scan all album, not only the selected ones
Summary: Face detection scan all album, not only the selected ones
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 7.2.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-07 15:57 UTC by mahikeulbody
Modified: 2021-03-09 17:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0
Sentry Crash Report:


Attachments
selector.png (15.92 KB, image/png)
2021-02-09 20:58 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mahikeulbody 2021-02-07 15:57:34 UTC
SUMMARY
Scan faces function scans all albums even an only one album is specified.

STEPS TO REPRODUCE
1. many albums never face-scanned (50000 files)
2. select an album (14 files) to detect faces in the dialog box of faces workflow
3. run detect faces

OBSERVED RESULT
The process take hours so one can think it is scanning all the albums, not the only one selected which contains only 14 files

EXPECTED RESULT
Faces detected only for the selected album

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 
Qt Version: 5.15.2

ADDITIONAL INFORMATION
digiKam Version 7.2.0-rc
Build date: 05/02/2021 18:07
Comment 1 Maik Qualmann 2021-02-07 18:23:29 UTC
No, digiKam definitely only scans the selected albums. You have probably selected some on the tab for tags, so that images with the keyword are also scanned. 

Maik
Comment 2 mahikeulbody 2021-02-08 08:19:28 UTC
You are right, I had "whole tags collection" checked. I thought that it was an AND of both search criterias. Btw that would be more logical, no ?

Anyway, sorry.
Comment 3 Maik Qualmann 2021-02-09 20:58:07 UTC
Created attachment 135543 [details]
selector.png

Would it help to show the number of selected albums / tags in the header tab? Or does it look strange?

Maik
Comment 4 mahikeulbody 2021-02-10 07:13:47 UTC
That seems a good idea.
(and may be also for the "search in" dialog of Similarity)
Comment 5 Maik Qualmann 2021-02-10 17:51:45 UTC
Git commit 0c44a700fa7807a59e7a59acc9c963c9a630bc2f by Maik Qualmann.
Committed on 10/02/2021 at 17:50.
Pushed by mqualmann into branch 'master'.

show selected Albums/Tags count in the tab header
FIXED-IN: 7.2.0

M  +27   -2    core/libs/album/widgets/albumselectors.cpp
M  +1    -0    core/libs/album/widgets/albumselectors.h

https://invent.kde.org/graphics/digikam/commit/0c44a700fa7807a59e7a59acc9c963c9a630bc2f
Comment 6 Ette 2021-03-09 17:03:15 UTC
I think it would e more logical and practical to combine both conditions with AND.
So people can search in Pictures in an Album which has the specific TAG.
The existing OR-condition doesn´t makes sense zo me.
Comment 7 Maik Qualmann 2021-03-09 17:26:46 UTC
It is an AND connection. You can choose albums AND images with a specific tag.

Maik