Bug 432578 - Missing space after a '.'
Summary: Missing space after a '.'
Status: RESOLVED FIXED
Alias: None
Product: kid3
Classification: Applications
Component: general (show other bugs)
Version: 3.8.x
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Urs Fleisch
URL:
Keywords:
: 446730 465246 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-06 17:12 UTC by seb.lebreton
Modified: 2023-02-04 07:53 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of kid3 illustrating the bug (150.12 KB, image/png)
2021-02-06 17:12 UTC, seb.lebreton
Details
kid3 118 screenshot (283.35 KB, image/png)
2021-03-18 19:45 UTC, seb.lebreton
Details
kid3 124 screenshot (338.61 KB, image/png)
2021-03-24 23:56 UTC, seb.lebreton
Details
Comparison of the latest version and the latest nightly build (#242) (458.70 KB, image/png)
2021-07-21 05:52 UTC, Vladimir Oleynik
Details
Fixed with kid3 3.9.0 / QT 6.2.2 (52.63 KB, image/png)
2021-12-18 21:58 UTC, seb.lebreton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description seb.lebreton 2021-02-06 17:12:26 UTC
Created attachment 135466 [details]
screenshot of kid3 illustrating the bug

SUMMARY

". " is replaced by a single "." (the space disappears) in both the filename and artist field display.


STEPS TO REPRODUCE
1. Load a file containing ". "
2. Observe the filename & tags displayed

OBSERVED RESULT

". " is replaced with "."
For instance : "Slim Thug feat. Big Chief And Lil Keke" appears as "Slim Thug feat.Big Chief And Lil Keke"

Note that it's only a display issue, the expected text above was directly copied from Kid3 and the ". " appears once pasted, but it's confusing and misleading (I actually added a space in kid3, thinking it was missing, but it resulted in my filename having an extra space, before I noticed it wasn't a display issue in kodi)

EXPECTED RESULT

Display the ". " text correctly

SOFTWARE/OS VERSIONS
macOS: 11.2 (M1 chip)
Qt Version: 5.9.7

ADDITIONAL INFORMATION

Screenshot attached
Comment 1 Urs Fleisch 2021-02-08 16:48:00 UTC
I cannot reproduce this. However, I do not have such a new model, only a Mac Mini, which cannot be upgraded beyond macOS 10.13 (High Sierra). On my Mac (and also on Linux and Windows) the space after the dot is clearly visible.
Could you check if you have the same problems with the version which can be downloaded at the top of https://binary-factory.kde.org/job/Kid3_Nightly_macos/? It is built with a slightly newer toolchain.
Comment 2 seb.lebreton 2021-03-18 19:45:46 UTC
Created attachment 136824 [details]
kid3 118 screenshot
Comment 3 seb.lebreton 2021-03-18 19:47:53 UTC
Hi, sorry for my late reply, unfortunately, it's still the same behavior with the latest build (118)

Attaching a screenshot where kid3 window and finder windows are visible.

In finder, "feat. Juicy" has the proper space
In kid3, all occurrences are missing the space (file browser on the left, "name" field on the top right, "title" frame in the id3v2.3.0 table.

Not sure what the process is, so I'm changing the status to reopen ?
Comment 4 Urs Fleisch 2021-03-19 16:58:49 UTC
Unfortunately, I cannot reproduce this on my Mac. However, this could also be due to the fact that I do not have the latest macOS and also the Mac version was not created with the latest SDK. Unfortunately, there is a reason for this, in fact that my Mac Mini 2010 no longer receives updates and therefore has to remain on macOS 10.13. I once tried a build with a newer Qt, but then the music playback didn't work anymore, the newest Qt versions don't work with macOS 10.13 at all.

But there is another alternative, namely the build which is created on the servers of the KDE Binary Factory. The package building capabilities there are somewhat limited, so the package is a bit fat, although it has fewer metadata plugins, actually only TagLib, but that should be enough as well. Could you test if the problems also occur with this build?

https://binary-factory.kde.org/job/Kid3_Nightly_macos/, then take the dmg there under "Last Successful Artifacts".
Comment 5 seb.lebreton 2021-03-24 23:56:33 UTC
Created attachment 137042 [details]
kid3 124 screenshot
Comment 7 Vladimir Oleynik 2021-07-17 17:43:19 UTC
This is a bug in Qt (QTBUG-88495). On MacOS 11 there is a problem with rendering of spaces after some characters (dots, commas, etc.). See the Qt Bug Tracker for details: https://bugreports.qt.io/browse/QTBUG-88495

This bug was fixed in Qt 5.15.3 which was released under a commercial license only (https://www.qt.io/blog/commercial-lts-qt-5.15.3-released).

I tried to build Kid3 with Qt 6 where this problem was also fixed and I can confirm that it solves this problem, missing spaces are now displayed.
Comment 8 seb.lebreton 2021-07-18 22:38:30 UTC
(In reply to Vladimir Oleynik from comment #7)

> I tried to build Kid3 with Qt 6 where this problem was also fixed and I can
> confirm that it solves this problem, missing spaces are now displayed.

Hi, thanks for the update !
Does this mean another version of kid3 is coming sometimes later with Qt 6 ? Any idea of a timetable for that ? It's obviously not a major bug but I'll be happy to update when the fix is integrated.
Comment 9 Urs Fleisch 2021-07-20 17:32:42 UTC
I am always trying to keep the code up to date, and therefore it is already adapted for Qt 6. None of the official versions, however, is already using it because it has not yet reached feature parity with Qt 5 - for Kid3 the missing module is QtMultimedia, so when you build it with Qt 6, there will be no playback available. QtMultimedia should be shipped with Qt 6.2, which will be released later this year.

Concerning the version for macOS, there is another problem: Qt 6 requires macOS 11.1 to build and at least macOS 10.14 to run. For my Mac Mini, Apple's support stops at macOS 10.13 (High Sierra), so I will not be able to run Qt 6 on it. Even if I am able to port my Linux cross toolchain to the macOS 11.1 SDK, I would not be able to test it. There may also be Kid3 users who do not have the latest hardware from Apple and who would not welcome it if Kid3 would raise its requirements to macOS 10.14.

So in the near future, I will probably continue to release Kid3 for macOS built with Qt 5. But you always have the possibility to build it from source (which should not be a huge challenge if you use the buildlibs.sh script coming with the sources). You could also try the nightly build from the KDE binary factory at https://binary-factory.kde.org/job/Kid3_Nightly_macos/, but I do not expect it to use Qt 6 as long as KDE is using Qt 5.
Comment 10 Vladimir Oleynik 2021-07-21 05:52:53 UTC
Created attachment 140229 [details]
Comparison of the latest version and the latest nightly build (#242)

Looks like bug was fixed in last nightly build (#242) https://binary-factory.kde.org/job/Kid3_Nightly_macos/242/
Comment 11 Urs Fleisch 2021-07-21 06:18:13 UTC
KDE maintains its own Qt 5.15 releases with a patch collection, see https://dot.kde.org/2021/04/06/announcing-kdes-qt-5-patch-collection. Probably the bug is fixed in their version of Qt 5.15.
Comment 12 seb.lebreton 2021-09-04 13:56:12 UTC
(In reply to Urs Fleisch from comment #9)

Thanks for info & workaround suggestion, but I will probably keep it simple and just use the official version for now. Maybe someday I will take the time to look at how to build it with QT6

But it seems like maybe the bug is also fixed with QT5.15, I'm just wondering how can I know when a new official version is released that integrates this version of QT so that I give it a try ?
Comment 13 Urs Fleisch 2021-12-18 03:44:31 UTC
*** Bug 446730 has been marked as a duplicate of this bug. ***
Comment 14 Urs Fleisch 2021-12-18 10:56:59 UTC
As this bug is only fixed in commercial editions of Qt 5.15 and in Qt 6, Kid3 3.9.0, which is built using the latest freely available version of Qt 5 (5.15.2), will probably still have this problem. However, I have published an additional version built against Qt 6.2.2, you can find it in https://sourceforge.net/projects/kid3/files/kid3/development/kid3-3.9.0-Darwin-Qt6-Mojave.dmg. Unfortunately, Qt 6 requires at least macOS 10.14 (Mojave, see https://doc.qt.io/qt-6/macos.html), which is not supported on my Mac Mini, so I am not able to test it. Could you please check if everything is working correctly with this version?
Comment 15 seb.lebreton 2021-12-18 21:58:23 UTC
Created attachment 144664 [details]
Fixed with kid3 3.9.0 / QT 6.2.2
Comment 16 seb.lebreton 2021-12-18 22:03:41 UTC
Hi,

I tested with 3.9.0 and the bug is indeed still there

With the version of 3.9.0 / QT6.2.2 that you linked, it looks good ! See screenshot attached.
I have only tested this specific use case however, so I'll start using this version from now on (unless there are known issues/limiations ?) and come back here if I notice anything.

Thanks a lot for the follow up & for providing the special version with the fix.
I'm not sure if I'm supposed to change the bug status myself to fixed or something, and whether it should be changed at all for now since it is only available in a special build, so I'm not touching anything and leaving it up to you.

Thanks again.
Comment 17 Urs Fleisch 2021-12-19 10:44:57 UTC
Good to hear that it seems to work so far. I will leave the bug open some time while you get some experience with the Qt 6 version. I do not know of any shortcomings or bugs in this version, it is built like the Qt 5 version from Linux using a cross compiler. What I was not able to test was audio playback, but Qt 6 builds for Linux and Windows had working audio output, so I would expect it to work. Another thing which has changed in Qt 6 is that there are not many text conversion codecs to convert between different charsets, so the "Text encoding" options offered in the "Tags/Tag 1" tab of the settings are quite reduced, but this is probably not a problem if you do not have ID3v1 tags with an encoding other the ASCII or ISO-8859-1 (which is not recommended anyway). So please report if you find any problems with the Qt 6 version. If it works satisfactorily, I will make this version an official alternative. Sooner or later, all versions will have to be built with Qt 6, so it is good to gain some experience beforehand.
Comment 18 seb.lebreton 2021-12-19 12:18:56 UTC
Thanks, I'll use it and report back here if I find something. Please ask if you need me to test something in particular or want an update.

BTW I never use audio within kid3 (didn't even know it is possible) so I won't know about those issues if any, and I always remove ID3v1 tags whenever I have one because iTunes/Music writes to ID3v2 so the encoding limitations shouldn't not be a problem.
Comment 19 seb.lebreton 2022-04-21 22:18:38 UTC
Hi, I've been using the 3.9.0 / QT6.2.2 for a while now, and I'm happy to report that I haven't noticed any side effect or bugs that could be related to QT6.

I have had a couple crashes, but both happened after the app stayed open for several day in background with in/out of sleep (and at least once with a folder loaded with 100s if not 1000s of songs) so it's not so critical, and I can't compare if it would have happen with the previous QT5 version.

So, as far as I'm concerned, this looks good and I will remove the other kid3 versions I still had installed (3.8.7, 3.9.0 with old QT)

I just saw that a new version is available now, 3.9.1, but I'm not sure which QT version it uses ?
Have you switched to QT6 on the main branch now ?

Thanks
Comment 20 seb.lebreton 2022-04-21 22:27:27 UTC
(I installled 3.9.1 and got my answer, it still uses QT5 so I will keep using the 3.9.0-QT6 build for now until official builds move to QT6)
Comment 21 Urs Fleisch 2022-04-22 02:48:39 UTC
There is a Mac version of Kid3 3.9.1 with Qt 6, it is even officially linked on https://kid3.kde.org/#download as "Qt 6 binaries for macOS Mojave or later kid3-3.9.1-Darwin-Qt6-Mojave.dmg" and points to https://prdownloads.sourceforge.net/kid3/kid3-3.9.1-Darwin-Qt6-Mojave.dmg?download.
Comment 22 seb.lebreton 2022-05-29 17:12:23 UTC
(In reply to Urs Fleisch from comment #21)
> There is a Mac version of Kid3 3.9.1 with Qt 6, it is even officially linked
> on https://kid3.kde.org/#download as "Qt 6 binaries for macOS Mojave or
> later kid3-3.9.1-Darwin-Qt6-Mojave.dmg" and points to
> https://prdownloads.sourceforge.net/kid3/kid3-3.9.1-Darwin-Qt6-Mojave.
> dmg?download.

Oh I didn't notice that, downloading now, thanks.
Comment 23 Urs Fleisch 2023-02-04 07:53:31 UTC
*** Bug 465246 has been marked as a duplicate of this bug. ***