Bug 432390 - Please add RTL window titlebars
Summary: Please add RTL window titlebars
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: window decoration (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: rtl
: 445509 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-01 17:26 UTC by Omeritzics
Modified: 2022-03-14 21:39 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24.4
Sentry Crash Report:


Attachments
KWin in LTR (running in RTL mode) (8.16 KB, image/png)
2021-09-19 14:24 UTC, Omeritzics
Details
How KWin titlebar should be in RTL (8.20 KB, image/png)
2021-09-19 14:25 UTC, Omeritzics
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Omeritzics 2021-02-01 17:26:49 UTC
Please make a RTL version of the window bars for the RTL languages.
Comment 1 Yaron Shahrabani 2021-09-19 04:47:26 UTC
Hey, can you be more specific and post relevant screenshots from the RTL version and possibly a reversed version of it?

Thanks.
Comment 2 Omeritzics 2021-09-19 14:23:20 UTC
(In reply to Yaron Shahrabani from comment #1)
> Hey, can you be more specific and post relevant screenshots from the RTL
> version and possibly a reversed version of it?
> 
> Thanks.

Hi, I am sorry for the late respond.
The text in the titlebar of RTL KWin is aligned to left, and the icons are ordered the same as in LTR KWin.
This is not an issue, but an inconsistency of the windows when both Qt and GTK applications are opened at the same time.
Comment 3 Omeritzics 2021-09-19 14:24:37 UTC
Created attachment 141701 [details]
KWin in LTR (running in RTL mode)
Comment 4 Omeritzics 2021-09-19 14:25:06 UTC
Created attachment 141702 [details]
How KWin titlebar should be in RTL
Comment 5 Safa Alfulaij 2022-01-02 08:00:24 UTC
*** Bug 445509 has been marked as a duplicate of this bug. ***
Comment 6 Bug Janitor Service 2022-03-02 16:19:53 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdecoration/-/merge_requests/19
Comment 7 Janet Blackquill 2022-03-14 21:38:29 UTC
Git commit 4123ec8c19936bea87b0aae3523f0062a16e62c5 by Janet Blackquill.
Committed on 02/03/2022 at 16:19.
Pushed by cblack into branch 'master'.

Add RtL support

This makes KDecoration2 able to handle right to left;
by properly mirroring buttons.

M  +30   -9    src/decorationbuttongroup.cpp

https://invent.kde.org/plasma/kdecoration/commit/4123ec8c19936bea87b0aae3523f0062a16e62c5
Comment 8 Janet Blackquill 2022-03-14 21:38:59 UTC
Git commit d6094ab116f1f8271f4d3e73b15cf4c1a6361df6 by Jan Blackquill, on behalf of Janet Blackquill.
Committed on 14/03/2022 at 21:38.
Pushed by cblack into branch 'Plasma/5.24'.

Add RtL support

This makes KDecoration2 able to handle right to left;
by properly mirroring buttons.
(cherry picked from commit 4123ec8c19936bea87b0aae3523f0062a16e62c5)

M  +30   -9    src/decorationbuttongroup.cpp

https://invent.kde.org/plasma/kdecoration/commit/d6094ab116f1f8271f4d3e73b15cf4c1a6361df6