Bug 432333 - Hibernate & network applet icon missing on Xfce
Summary: Hibernate & network applet icon missing on Xfce
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-31 07:24 UTC by Or Schiro
Modified: 2021-08-15 13:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.86
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Or Schiro 2021-01-31 07:24:15 UTC
Hi all!

Breeze is beautiful and I would love to use it on Xfce. 

However, currently there are no icons for hibernate and the network applet. 

Is this something that could be added?

See this discussion for further reference:

https://forum.xfce.org/viewtopic.php?id=14698

Thank you!
Comment 1 Nate Graham 2021-01-31 16:51:18 UTC
Yay, I'm glad you like it!

Can you provide the name of the icons that are missing? What are the icon names that XFCE is looking for?
Comment 2 Or Schiro 2021-02-01 13:27:58 UTC
Thanks Nate!

On Xfce 4.14 they are called:

Network:

- nm-device-wired.svg
- nm-no-connection.svg
- nm-nm-signal-00.svg
- nm-nm-signal-25.svg
- nm-nm-signal-50.svg
- nm-nm-signal-75.svg
- nm-nm-signal-100.svg

Hibernate:

- system-hibernate.svg

On Xfce 4.16 (upcoming) they are going to be called:

Hibernate:

- xfsm-hibernate

Network:

- org.xfce.gigolo
Comment 3 Nate Graham 2021-02-01 16:02:22 UTC
> nm-device-wired.svg
This is "wired internet connection connected"?

> nm-no-connection.svg
This is "wired internet connection disconnected"?

> nm-nm-signal-*
These are icons for wifi signal strength?

> org.xfce.gigolo
I don't understand, can you clarify?
Comment 4 Or Schiro 2021-02-01 19:32:29 UTC
> This is "wired internet connection connected"?

Yes.

> This is "wired internet connection disconnected"?

This is no all connections disconnected.

> These are icons for wifi signal strength?

Yes.

> I don't understand, can you clarify?

I am not entirely sure myself but I believe with Xfce 4.16 there is just going to be one single network icon called like that.

See: https://wiki.xfce.org/releng/4.16/icons_rdns_naming_for_icons
Comment 5 Nate Graham 2021-02-01 20:13:07 UTC
(In reply to Or Schiro from comment #4)
> I am not entirely sure myself but I believe with Xfce 4.16 there is just
> going to be one single network icon called like that.
> 
> See: https://wiki.xfce.org/releng/4.16/icons_rdns_naming_for_icons
OK. And what should this icon look like?
Comment 6 Or Schiro 2021-02-02 13:35:08 UTC
Hi Nate!

I was told to share this script with you: 

https://gist.github.com/bluesabre/582d886a02c793285f4e3081df9b2a3c

Does that help?
Comment 7 Nate Graham 2021-02-02 16:30:23 UTC
Not really, sorry. That script tells me that the "org.xfce.gigolo" icon is supposed to look like the "gtk-network" icon but I don't know what that icons looks like! We don't have an icon by that name in the Breeze icon theme, and I can't find one in the Adwaita icon theme either at https://gitlab.gnome.org/GNOME/adwaita-icon-theme.

Can you find out what that icon looks like so I know which Breeze icon to use?
Comment 8 Or Schiro 2021-02-03 12:01:43 UTC
Here is what I found: https://gitlab.xfce.org/apps/gigolo
Comment 9 Nate Graham 2021-02-03 18:34:58 UTC
Okay so a generic network icon? Should it be colorful or monochrome?
Comment 10 Or Schiro 2021-02-03 20:15:49 UTC
I'd say monochrome!
Comment 11 Nate Graham 2021-02-03 21:11:37 UTC
All right, can do.
Comment 12 Bug Janitor Service 2021-02-04 03:52:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/82
Comment 13 Or Schiro 2021-02-04 06:58:47 UTC
Thanks so much, Nate!
Comment 14 Nate Graham 2021-08-06 18:21:00 UTC
Git commit 04a13e272dd395442e7eb9dc58de3ab55a2f22f3 by Nate Graham.
Committed on 06/08/2021 at 16:04.
Pushed by ngraham into branch 'master'.

Add Xfce compatibility symlinks

This commit adds the necessary compatibility symlinks to allow the
Breeze icon theme to be used on Xfce.
FIXED-IN: 5.85

A  +1    -0    icons-dark/actions/22/system-hibernate.svg
A  +1    -0    icons-dark/actions/22/xfsm-hibernate.svg
A  +1    -0    icons-dark/actions/32/system-hibernate.svg
A  +1    -0    icons-dark/actions/32/xfsm-hibernate.svg
A  +1    -0    icons-dark/places/16/org.xfce.gigolo.svg
A  +1    -0    icons-dark/places/22/org.xfce.gigolo.svg
A  +1    -0    icons-dark/status/22/nm-device-wired.svg
A  +1    -0    icons-dark/status/22/nm-nm-signal-00.svg
A  +1    -0    icons-dark/status/22/nm-nm-signal-100.svg
A  +1    -0    icons-dark/status/22/nm-nm-signal-25.svg
A  +1    -0    icons-dark/status/22/nm-nm-signal-50.svg
A  +1    -0    icons-dark/status/22/nm-nm-signal-75.svg
A  +1    -0    icons-dark/status/22/nm-no-connection.svg
A  +1    -0    icons/actions/22/system-hibernate.svg
A  +1    -0    icons/actions/22/xfsm-hibernate.svg
A  +1    -0    icons/actions/32/system-hibernate.svg
A  +1    -0    icons/actions/32/xfsm-hibernate.svg
A  +1    -0    icons/places/16/org.xfce.gigolo.svg
A  +1    -0    icons/places/22/org.xfce.gigolo.svg
A  +1    -0    icons/status/22/nm-device-wired.svg
A  +1    -0    icons/status/22/nm-nm-signal-00.svg
A  +1    -0    icons/status/22/nm-nm-signal-100.svg
A  +1    -0    icons/status/22/nm-nm-signal-25.svg
A  +1    -0    icons/status/22/nm-nm-signal-50.svg
A  +1    -0    icons/status/22/nm-nm-signal-75.svg
A  +1    -0    icons/status/22/nm-no-connection.svg

https://invent.kde.org/frameworks/breeze-icons/commit/04a13e272dd395442e7eb9dc58de3ab55a2f22f3