Bug 432312 - Detect Faces crashes when .xcf file encountered
Summary: Detect Faces crashes when .xcf file encountered
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Detection (show other bugs)
Version: 7.1.0
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-30 13:18 UTC by Androo
Modified: 2021-01-31 12:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Androo 2021-01-30 13:18:30 UTC
SUMMARY
Repeated crashes trying to use Detect Faces for the first time on a large library.  Presence of .xcf files seem to cause it.

STEPS TO REPRODUCE
1. Navigate to People tab
2. Select Detect Faces, Skip already scanned, Search whole library, all cores
3. wait for crash

OBSERVED RESULT
Crashed early on, so I could guess which folder it was scanning. Checked that folder's contents, ran detection again. I moved the .xcf out after second crash. Scan proceeded farther until another crash, folder unknown. Hard to determine which file may be responsible.

EXPECTED RESULT
Run to completion

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2021-01-30 13:29:58 UTC
Please try with current 7.2.0 release candidate available here :

https://files.kde.org/digikam/


Gilles Caulier
Comment 2 Androo 2021-01-30 14:47:23 UTC
Running.

Meanwhile 
1) Error on every launch wtih RC 7.2 digikam.exe
"The procedure entry point dbgcore.MiniDumpReadDumpStream could not be located in the dynamic link library dbghelp.dll"

2) I saved the last APPCRASH from 7.1, for what it's worth
Problem signature:
  Problem Event Name:	APPCRASH
  Application Name:	digikam.exe
  Application Version:	0.0.0.0
  Application Timestamp:	00000000
  Fault Module Name:	Qt5Widgets.dll
  Fault Module Version:	5.15.0.0
  Fault Module Timestamp:	00000000
  Exception Code:	c0000005
  Exception Offset:	000000000002e8e4
  OS Version:	6.1.7601.2.1.0.256.48
  Locale ID:	1033
  Additional Information 1:	ff90
  Additional Information 2:	ff90f5dfb9f6b307a322ad503905f444
  Additional Information 3:	640b
  Additional Information 4:	640bc18688ffff9bb554d4f8559d256a
Comment 3 Maik Qualmann 2021-01-30 16:46:51 UTC
We already know the error message of dbghelp.dll, you are probably still using Windows7. DigiKam works anyway. Can the problem with .xcf files still be reproduced?

Maik
Comment 4 caulier.gilles 2021-01-30 16:48:12 UTC
Maik,

i will remove the dbghelp.dll from the bundle to not seen this problem in the future, until we found a solution.

Gilles
Comment 5 Maik Qualmann 2021-01-30 17:52:57 UTC
We may have to register our dbghelp.dll with regsvr32 and unregister it again when uninstalling digiKam. I'll check it on Monday on the Windows7 computer.

Maik
Comment 6 Androo 2021-01-30 21:27:12 UTC
Thank you for your quick help. RC 7.2 ran the face detection all the way through the remaining photos with no problem. Very nice!
Comment 7 caulier.gilles 2021-01-31 04:15:01 UTC
To Maik comment #5:

The solution can be to simply force to load the dbghelp.dll first at startup. Look here:

https://invent.kde.org/graphics/digikam/-/blob/master/core/app/utils/digikam_globals.cpp#L236

Gilles
Comment 8 Maik Qualmann 2021-01-31 09:19:43 UTC
Git commit e50920804628ba30c4b43ddc8c8975020b28a024 by Maik Qualmann.
Committed on 31/01/2021 at 09:19.
Pushed by mqualmann into branch 'master'.

try to load dbghelp.dll and polish wchar_t* conversion

M  +14   -10   core/app/utils/digikam_globals.cpp

https://invent.kde.org/graphics/digikam/commit/e50920804628ba30c4b43ddc8c8975020b28a024
Comment 9 Maik Qualmann 2021-01-31 09:21:26 UTC
Gilles,

compilation and functionality is untested. I have to build an MXE first. Can you please initiate a Windows bundle compilation?

Maik
Comment 10 caulier.gilles 2021-01-31 09:22:31 UTC
yes sure; i start it immediately...

Gilles
Comment 11 Maik Qualmann 2021-01-31 11:15:15 UTC
The problem persists under Windows7. Under Windows 10 everything works as usual. Since the dbghelp.dll cannot be registered with regsvr32 either, since the entry point for it does not exist, my suggestion is that we do not activate Dr.MinGW under Windows7. Windows7 plays less and less of a role.

Maik
Comment 12 Maik Qualmann 2021-01-31 12:32:11 UTC
Git commit 37b20f5931054c8f99ca3e6734cd3bcd14f3efb7 by Maik Qualmann.
Committed on 31/01/2021 at 12:29.
Pushed by mqualmann into branch 'master'.

check for unsupported versions of Windows

M  +22   -0    core/app/utils/digikam_globals.cpp

https://invent.kde.org/graphics/digikam/commit/37b20f5931054c8f99ca3e6734cd3bcd14f3efb7