Bug 432302 - Clicking on a file which is result of search operation is not positioning cursor over the file/directory
Summary: Clicking on a file which is result of search operation is not positioning cur...
Status: RESOLVED NOT A BUG
Alias: None
Product: krusader
Classification: Applications
Component: search (show other bugs)
Version: 2.7.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
: 435121 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-30 07:47 UTC by Marko
Modified: 2021-04-16 20:22 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Krusader won't position cursor over directory when it's double-clicked or pushed enter on it, in search results. (317.73 KB, video/mp4)
2021-02-08 06:13 UTC, Marko
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marko 2021-01-30 07:47:48 UTC
SUMMARY
Clicking on a file which is result of search operation is not positioning cursor over the file as it should, instead just closes the window which is report of search operation

STEPS TO REPRODUCE
1. CTRL-S to search
2. Search so that you get result(s)
3. In search results, click on some file/directory

OBSERVED RESULT
It just closes the window with search results

EXPECTED RESULT
Close the window with search results, and then position cursor over the wanted file/directory

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 2.7.2
(available in About System)
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8

ADDITIONAL INFORMATION
Contact me for bounty for solution for this bug.
Comment 1 Davide Gianforte 2021-02-03 06:47:45 UTC
I've tested it on several systems: when you click on an item in the results pane, the search window is minimized (not closed), the focus returns to the main window (active panel) and the position is placed on the clicked item.

If you're handy with code, you can look in krusader/Search/krsearchdialog.cpp KrSearchDialog::executed (https://invent.kde.org/utilities/krusader/-/blob/master/krusader/Search/krsearchdialog.cpp#L433).

You mean that the item should be selected (like pressing Space after been returned to the panel) or the panel does not change the current item?
Comment 2 Marko 2021-02-03 12:45:32 UTC
I don't think it shoukd be selected, just positioned over, and that's not happening here. Think I'll record a video so you can see.
Comment 3 Marko 2021-02-03 15:16:09 UTC
I just checked again, and I'm pretty sure it wasn't functioning when it comes to both files and directories. But now it functions for files, but not directories. So that's it, if you really insist, I can make a video.
Comment 4 Toni Asensi Esteve 2021-02-06 18:04:25 UTC
> I just checked again, and I'm pretty sure it wasn't functioning when it comes
> to both files and directories. But now it functions for files, but not
> directories. So that's it, if you really insist, I can make a video.            

Maybe a video could help. I tried to reproduce the problem, though I only saw something similar in the known case of a file that was listed in the result of a search operation but... later was deleted or renamed (although its name was still present in the result of the search operation, so a later double-clicking did not find the file).
Comment 5 Marko 2021-02-08 06:13:17 UTC
Created attachment 135498 [details]
Krusader won't position cursor over directory when it's double-clicked or pushed enter on it, in search results.

I added .mp4 video recorded which shows this bug.
Comment 6 Bug Janitor Service 2021-02-24 04:33:15 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Marko 2021-02-24 05:49:25 UTC
Changed the status to REPORTED. Added .mp4 file that shows the bug.
Comment 8 Toni Asensi Esteve 2021-04-15 20:24:08 UTC
*** Bug 435121 has been marked as a duplicate of this bug. ***
Comment 9 Toni Asensi Esteve 2021-04-15 20:28:19 UTC
Possibly related: [Select item from search window](https://phabricator.kde.org/D26334).

Can you follow the steps of
    https://commits.kde.org/krusader?path=INSTALL
in order to build the git version of Krusader and tell us if your problem is solved?
Comment 10 Toni Asensi Esteve 2021-04-16 20:09:38 UTC
The status of this bug report was changed.
Comment 11 Marko 2021-04-16 20:13:42 UTC
Guys, I'm just not that technical nor I have time to compile git version to check. I just wanted to let you know this, so somebody other can check. I would really love to see this bug solved though, thanks!
Comment 12 Toni Asensi Esteve 2021-04-16 20:22:15 UTC
> Guys, I'm just not that technical nor I have time to compile git version to 
> check. I just wanted to let you know this, so somebody other can check. I would 
> really love to see this bug solved though, thanks!

It seems that the bug was solved last year (https://phabricator.kde.org/D26334), although a new version of Krusader has not been released, and Krusader developers use the git version of Krusader.

So, this bug report has to be closed. Feel free to reopen this bug report if it's needed (for example, if you build the latest git version of Krusader and you still see the bug). Greetings!