Bug 432091 - Inconsistent effect when I hover over the new Keyboard Layout applet
Summary: Inconsistent effect when I hover over the new Keyboard Layout applet
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Keyboard Layout (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Andrey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-25 11:29 UTC by Patrick Silva
Modified: 2021-02-11 11:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (17.84 KB, image/png)
2021-01-25 11:29 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-01-25 11:29:39 UTC
Created attachment 135160 [details]
screenshot

SUMMARY
As we can see in the attached screenshot, blue border appears when I hover over the new Keyboard Layout applet on Wayland session. No other applet present in system tray has this effect on mouseover.

EXPECTED RESULT
Same effect when we hover over any applet in system tray.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.21.80
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Comment 1 Andrey 2021-01-25 12:38:27 UTC
Hi Patrick, thanks for reporting.
This is a known problem, it will be kinda "solved" eventually.

Just need to warn you - while we can get rid of that blue border and other "button" effects, the trade of would be we won't have any hover effect on text applet representation at all. It will be for flag representation, though.

Do you think it's a problem?
Comment 2 Patrick Silva 2021-01-25 12:45:47 UTC
(In reply to Andrey from comment #1)
> Hi Patrick, thanks for reporting.
> This is a known problem, it will be kinda "solved" eventually.
> 
> Just need to warn you - while we can get rid of that blue border and other
> "button" effects, the trade of would be we won't have any hover effect on
> text applet representation at all. It will be for flag representation,
> though.
> 
> Do you think it's a problem?

No. I think that no effect is better than the current blue border.
Comment 3 Andrey 2021-01-26 12:16:31 UTC
Patrick,
FYI, the applet can be loaded on panel, desktop, etc. in X also so this bug is not Wayland-specific.
Comment 4 Bug Janitor Service 2021-02-10 23:19:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/347
Comment 5 Andrey 2021-02-11 11:20:35 UTC
Git commit 9ade13ea0385c5ba1b2d94542efe9c792b4f8307 by Andrey Butirsky.
Committed on 11/02/2021 at 11:20.
Pushed by butirsky into branch 'master'.

fix: Inconsistent effect when hover over the new Keyboard Layout applet

Disable blue outline on hover and opaque blue background on press
effects.
Enable highlight on hover for icon representation.

M  +3    -0    applets/keyboardlayout/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/9ade13ea0385c5ba1b2d94542efe9c792b4f8307
Comment 6 Andrey 2021-02-11 11:21:25 UTC
Git commit 0f6232af811cf39804e8ee7ead5f1a732a7e7014 by Andrey Butirsky.
Committed on 11/02/2021 at 11:21.
Pushed by butirsky into branch 'Plasma/5.21'.

fix: Inconsistent effect when hover over the new Keyboard Layout applet

Disable blue outline on hover and opaque blue background on press
effects.
Enable highlight on hover for icon representation.


(cherry picked from commit 9ade13ea0385c5ba1b2d94542efe9c792b4f8307)

M  +3    -0    applets/keyboardlayout/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/0f6232af811cf39804e8ee7ead5f1a732a7e7014